Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLIENT:PAM: fixed missed return check #5317

Closed
wants to merge 1 commit into from
Closed

CLIENT:PAM: fixed missed return check #5317

wants to merge 1 commit into from

Commits on Sep 16, 2020

  1. CLIENT:PAM: fixed missed return check 

    Return code of `prompt_2fa()` wasn't checked and
thus its fail wasn't properly processed.

Spotted with a help of following warning:
```
Error: CLANG_WARNING:
sssd-2.3.2/src/sss_client/pam_sss.c:2355:21: warning: Value stored to 'ret' is never read
 #                    ret = prompt_2fa(pamh, pi, _("First Factor (Current Password): "),
 #                    ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
    @alexey-tikhonov
    alexey-tikhonov committed Sep 16, 2020
    Copy the full SHA
    e402bd9 View commit details
    Browse the repository at this point in the history