Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

be: remove accidental sleep #5344

Closed
wants to merge 1 commit into from
Closed

Conversation

pbrezina
Copy link
Member

@pbrezina pbrezina commented Oct 1, 2020

This sleep was used to test a crash in data provider and quite unfortunately
it was left in the patch.

dp: fix potential race condition in provider's sbus server
4a84f8e.

Perhaps this is the cause of recent failures in session recording tests.

This sleep was used to test a crash in data provider and quite unfortunately
it was left in the patch.

dp: fix potential race condition in provider's sbus server
4a84f8e.
@alexey-tikhonov
Copy link
Member

Oops...
ACK.

@pbrezina
Copy link
Member Author

pbrezina commented Oct 1, 2020

Thanks for quick review, I'll push it and re-run failed CIs to get more runs and to see if it helps or the issue in tests persist.

@pbrezina
Copy link
Member Author

pbrezina commented Oct 1, 2020

Pushed PR: #5344

  • master
    • 7fbcaa8 - be: remove accidental sleep

@pbrezina pbrezina added Pushed and removed Accepted Ready to push Ready to push labels Oct 1, 2020
@pbrezina pbrezina closed this Oct 1, 2020
@pbrezina pbrezina deleted the dontsleep branch April 13, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants