Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TESTS: KCM: Increase client idle timeout to 5 minutes #5413

Closed
wants to merge 1 commit into from
Closed

TESTS: KCM: Increase client idle timeout to 5 minutes #5413

wants to merge 1 commit into from

Conversation

aborah-sudo
Copy link
Contributor

@aborah-sudo aborah-sudo commented Nov 22, 2020 •
edited by sgoveas

By default, KCM has a 60-second idle client timeout. This might not be
enough, because the client is often kinit, so there is some user
interaction involved.

Verifies:
Issue: #4829
Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1884205

@sgoveas
Copy link
Contributor

sgoveas commented Nov 23, 2020

Please resolve the pep8 issue
https://s3.eu-central-1.amazonaws.com/sssd-ci/PR-5413/1/rhel8/ci-pep8.log.

You can click on 'Details' to get more information on the failing tests

@pbrezina pbrezina changed the title KCM: Increase client idle timeout to 5 minutes TESTS: KCM: Increase client idle timeout to 5 minutes Nov 23, 2020
@pbrezina
Copy link
Member

pbrezina commented Nov 23, 2020 •
edited

Can you please make it clear from the commit message that you add test and not functionality? E.g. prefix it with TESTS:

@aborah-sudo
Copy link
Contributor Author

@sgoveas , @pbrezina done .

@aborah-sudo aborah-sudo requested review from sgoveas and removed request for sgoveas December 3, 2020 12:11
@madhuriupadhye
Copy link
Contributor

Also as it's a KCM bug please create the test_kcm.py to add all kcm related bugs.
We use test_misc.py only when we can not predict such a feature from the bug.

@sgoveas
Copy link
Contributor

sgoveas commented Jan 14, 2021

Please update marker to 'tier1_2' for tier1 tests

@aborah-sudo
TESTS:KCM: Increase client idle timeout to 5 minutes
f6b2ecb 
By default, KCM has a 60-second idle client timeout.
This might not be enough, because the client is often kinit,
so there is some user interaction involved.

Verifies: #4829

Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1884205
@aborah-sudo
Copy link
Contributor Author

Also as it's a KCM bug please create the test_kcm.py to add all kcm related bugs.
We use test_misc.py only when we can not predict such a feature from the bug.

Done

@aborah-sudo
Copy link
Contributor Author

Please update marker to 'tier1_2' for tier1 tests

Done

@pbrezina pbrezina assigned madhuriupadhye and unassigned sgoveas Jan 15, 2021
@pbrezina pbrezina added the Ready to push Ready to push label Jan 15, 2021
@pbrezina
Copy link
Member

Pushed PR: #5413

  • master
    • 39c5281 - TESTS:KCM: Increase client idle timeout to 5 minutes

@pbrezina pbrezina removed Accepted Ready to push Ready to push labels Jan 15, 2021
@pbrezina pbrezina closed this Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madhuriupadhye madhuriupadhye madhuriupadhye left review comments

Assignees

@madhuriupadhye madhuriupadhye

Labels
Pushed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aborah-sudo @sgoveas @pbrezina @madhuriupadhye