Covscan fixes #5526
Closed
Covscan fixes #5526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Covscan is confused by dangling pointers in arrays after freeing. Its analyzer may decide to visit already visited list elements and since they weren't NULL-ed, it may consider double-free to happen in the code. Signed-off-by: Alexander Bokovoy <abokovoy@redhat.com>
covscan does consider 'ret' unitialized even though GET_ATTR/GET_ATTR_ARRAY macros have explicit and unconditional assignment to ret. This is confusing but causing actual failures in covscan runs. Signed-off-by: Alexander Bokovoy <abokovoy@redhat.com>
Author: Alexander Bokovoy <abokovoy@redhat.com> Amended by: Alexey Tikhonov <atikhono@redhat.com> (used 'EINVAL' as error code instead of 'ENOMEM')
|
Those patches were already reviewed by me, but I'm not sure if I can set ACK as I changed one patch a little bit. Second look won't hurt anyway. covscan: https://cov01.lab.eng.brq.redhat.com/covscanhub/task/208327/log/fixed.err (sorry for internal link) |
|
Ack. |
pbrezina
added
Accepted
Ready to push
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is overtake of PR #5498 (based on #5498 (comment) comment)
Two patches were taken "as is".
Patch "symlink() expects non-NULL second argument" was slightly amended (different error code used).
One patch was skipped as I either don't understand it or it's not entirely correct.