Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: automount sssd issue when 2 automount maps have the same key #5619

Closed
wants to merge 1 commit into from
Closed

Tests: automount sssd issue when 2 automount maps have the same key #5619

wants to merge 1 commit into from

Conversation

aborah-sudo
Copy link
Contributor 

(one un uppercase, one in lowercase)

With 2 automount entries in LDAP with same key ( cn: MIT and cn: mit),
autofs only works for one of them ( the one in uppercase )

@aborah-sudo aborah-sudo requested a review from sgoveas May 4, 2021 06:22
@aborah-sudo aborah-sudo self-assigned this May 4, 2021
sgoveas
sgoveas suggested changes May 5, 2021
View reviewed changes
Copy link
Contributor

@sgoveas sgoveas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this test can be added to test_automount.py

src/tests/multihost/alltests/pytest.ini Outdated Show resolved Hide resolved
src/tests/multihost/alltests/readme.rst Outdated Show resolved Hide resolved
src/tests/multihost/alltests/test_autofs.py Outdated Show resolved Hide resolved
src/tests/multihost/alltests/test_autofs.py Outdated Show resolved Hide resolved
src/tests/multihost/alltests/test_autofs.py Outdated Show resolved Hide resolved
sgoveas
sgoveas suggested changes May 7, 2021
View reviewed changes
Copy link
Contributor

@sgoveas sgoveas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add bugzilla and ticket link in commit message

src/tests/multihost/alltests/test_automount.py Outdated Show resolved Hide resolved
Tests: automount sssd issue when 2 automount maps have the same key
8007a71 
	(one un uppercase, one in lowercase)

With 2 automount entries in LDAP with same key ( cn: MIT and cn: mit),
autofs only works for one of them ( the one in uppercase )

Verifies: #5330

Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1873715
sgoveas
sgoveas approved these changes May 7, 2021
View reviewed changes
Copy link
Contributor

@sgoveas sgoveas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@pbrezina pbrezina added the Ready to push Ready to push label May 10, 2021
@pbrezina pbrezina assigned sgoveas and unassigned aborah-sudo May 10, 2021
@pbrezina
Copy link
Member

Pushed PR: #5619

  • master
    • 47b40cc - Tests: automount sssd issue when 2 automount maps have the same key (one un uppercase, one in lowercase)

@pbrezina pbrezina added Pushed and removed Accepted Ready to push Ready to push labels May 10, 2021
@pbrezina pbrezina closed this May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgoveas sgoveas sgoveas approved these changes

Assignees

@sgoveas sgoveas

Labels
Pushed Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aborah-sudo @pbrezina @sgoveas