Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSSD man: man_dns_resolver_parameter_modification #5645

Closed

Conversation

DDDas7
Copy link
Contributor

@DDDas7 DDDas7 commented May 20, 2021

Adding parameter dns_resolver_server_timeout
and dns_resolver_op_timeout in sssd.conf

Resolves: #5616

@DDDas7 DDDas7 force-pushed the man_dns_resolver_parameter_modification branch from 45600ee to de7d32c Compare May 20, 2021 15:21
src/man/sssd.conf.5.xml Outdated Show resolved Hide resolved
src/man/sssd.conf.5.xml Outdated Show resolved Hide resolved
Adding parameter dns_resolver_server_timeout
and dns_resolver_op_timeout in sssd.conf

Resolves: SSSD#5616
@DDDas7 DDDas7 force-pushed the man_dns_resolver_parameter_modification branch from 25843fc to 9ab6cc0 Compare May 20, 2021 15:45
<para>
Defines the amount of time (in milliseconds)
SSSD would try to talk to DNS server before
trying next DNS server.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I read this a couple times but it's not really clear to me what it means.

I interpret this as SSSD would try to talk to a DNS server for 1 second before trying a next DNS server, but why would SSSD only communicate with a DNS server for 1 second? Does it mean SSSD connects to a DNS server but only waits for a response for 1 second?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the timer is only used to resolve the DNS server, once it's resolved the timer no longer applies.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have rephrased the complete sentence. Can you pls check the latest changes.

Also I have split the dns_resolver_* parameters from “failover.xml” and created a new file “dns_options.xml” to sync the parameter definition since currently the definition for the parameter “dns_resolver_timeout” is different in files “failover.xml” and “sssd.conf.5.xml”.

It will help maintaining the dns_resolver_* parameters definition from a single file.

@DDDas7 DDDas7 changed the title SSSD man: man_dns_resolver_parameter_modification [WIP] SSSD man: man_dns_resolver_parameter_modification May 21, 2021
Adding parameter dns_resolver_server_timeout
and dns_resolver_op_timeout in sssd.conf

Resolves: SSSD#5616
@DDDas7 DDDas7 changed the title [WIP] SSSD man: man_dns_resolver_parameter_modification SSSD man: man_dns_resolver_parameter_modification May 22, 2021
@DDDas7 DDDas7 force-pushed the man_dns_resolver_parameter_modification branch from 6a60c15 to addf2a6 Compare May 22, 2021 19:32
Adding parameter dns_resolver_server_timeout
and dns_resolver_op_timeout in sssd.conf

Resolves: SSSD#5616
@DDDas7 DDDas7 force-pushed the man_dns_resolver_parameter_modification branch from addf2a6 to 5c422e6 Compare May 22, 2021 19:43
@ikerexxe
Copy link
Contributor

LGTM! @justin-stephenson can you do a final review?

@justin-stephenson
Copy link
Contributor

LGTM! @justin-stephenson can you do a final review?

Ack, thanks Deepak !

@pbrezina
Copy link
Member

Pushed PR: #5645

  • master
    • 7190f6b - SSSD man: man_dns_resolver_parameter_modification
    • 43b9b09 - SSSD man: man_dns_resolver_parameter_modification

@pbrezina pbrezina added Pushed and removed Accepted Ready to push Ready to push labels May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sssd.conf man page: parameter dns_resolver_server_timeout and dns_resolver_op_timeout
4 participants