Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: SSSD logs improvements: clarify which config option applies to... #5730

Closed
wants to merge 1 commit into from
Closed

Tests: SSSD logs improvements: clarify which config option applies to... #5730

wants to merge 1 commit into from

Conversation

aborah-sudo
Copy link
Contributor

… each timeout in the logs

issue: #5514

bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1928648

@aborah-sudo aborah-sudo requested a review from sgoveas July 30, 2021 04:44
@aborah-sudo aborah-sudo self-assigned this Jul 30, 2021
sgoveas
sgoveas suggested changes Sep 16, 2021
View reviewed changes
src/tests/multihost/alltests/test_offline.py Show resolved Hide resolved
src/tests/multihost/alltests/test_offline.py Outdated Show resolved Hide resolved
src/tests/multihost/alltests/test_offline.py Outdated Show resolved Hide resolved
src/tests/multihost/alltests/test_offline.py Outdated Show resolved Hide resolved
src/tests/multihost/alltests/test_offline.py Outdated Show resolved Hide resolved
sgoveas
sgoveas approved these changes Sep 19, 2021
View reviewed changes
Copy link
Contributor

@sgoveas sgoveas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@pbrezina pbrezina changed the title Tests: SSSD logs improvements: clarify which config option applies to… Tests: SSSD logs improvements: clarify which config option applies to... Sep 20, 2021
@pbrezina
Copy link
Member

Please fix pep8 errors:
https://s3.eu-central-1.amazonaws.com/sssd-ci/PR-5730/2/fedora-rawhide/ci-pep8.log

@aborah-sudo
Copy link
Contributor Author

Please fix pep8 errors:
https://s3.eu-central-1.amazonaws.com/sssd-ci/PR-5730/2/fedora-rawhide/ci-pep8.log

Fixed

@pbrezina pbrezina added the Ready to push Ready to push label Sep 24, 2021
@pbrezina
Copy link
Member

Pushed PR: #5730

  • master
    • aab4fe9 - Tests: SSSD logs improvements: clarify which config option applies to each timeout in the logs

@pbrezina pbrezina added Pushed and removed Accepted Ready to push Ready to push labels Sep 24, 2021
@pbrezina pbrezina closed this Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgoveas sgoveas sgoveas approved these changes

Assignees

@aborah-sudo aborah-sudo

Labels
Pushed Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aborah-sudo @pbrezina @sgoveas @alexey-tikhonov