util: Avoid an extern variable by using sss_chain_id_get()

[cryptomilk]

No description provided.

[alexey-tikhonov]

In general this feels cleaner but this would require inclusion of sss_chain_id.c to libsss_debug:

libsss_debug.so: undefined reference to `sss_chain_id_get'

and this, in turn, would require linking against libtevent (not the case currently and probably better to be avoided as libsss_debug is used in different helpers that doesn't link against libtevent)

[alexey-tikhonov]

Other functions in sss_chain_id.c still need to access debug_chain_id

[alexey-tikhonov]

I guess include of stdint.h is missing in debug.h

But, in general, I'm not sure the split of sss_chain_id_* functions to different files is much better then single extern var...

[pbrezina]

We already have multiple extern debug variables. Removing this one with the cost of splitting the implementation seems as unnecessary paranoia. Additionally, the main reason that I access the variable directly inside sss_chain_id.c is to avoid unnecessary functions calls since it has little impact in performance (negligible that's true, but easily avoided) .

I'll leave it to others to decide. Also _get should be inlined.

[cryptomilk]

Then lets just close it ... :-)