Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONF: removed unused 'sbus_timeout' option #5803

Closed

Conversation

alexey-tikhonov
Copy link
Member

@ikerexxe
Copy link
Contributor

ikerexxe commented Oct 6, 2021

The changes look good to me but I think that you should link an upstream ticket both in the commit message and in the PR description.

Moreover, I wonder if we should notify in the next release that the option is no longer available.

@alexey-tikhonov
Copy link
Member Author

The changes look good to me but I think that you should link an upstream ticket both in the commit message and in the PR description.

Moreover, I wonder if we should notify in the next release that the option is no longer available.

But the options was NOT available. I mean, putting this option in sssd.conf did NOT have any effect.
This is merely removal of code that did nothing, so I don't think it's worth a ticket and especially a RN.

@ikerexxe
Copy link
Contributor

ikerexxe commented Oct 6, 2021

But the options was NOT available. I mean, putting this option in sssd.conf did NOT have any effect. This is merely removal of code that did nothing, so I don't think it's worth a ticket and especially a RN.

In that case, everything looks good to me. Thanks for the patch!

@pbrezina
Copy link
Member

pbrezina commented Oct 7, 2021

Pushed PR: #5803

  • master
    • c4c0fd6 - CONF: removed unused 'sbus_timeout' option

@pbrezina pbrezina added Pushed and removed Accepted Ready to push Ready to push labels Oct 7, 2021
@pbrezina pbrezina closed this Oct 7, 2021
@alexey-tikhonov alexey-tikhonov deleted the remove_sbus_timeout branch March 31, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants