Tests: pam_sss_gss.so doesn't work with large kerberos tickets #5815 #5817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborah-sudo
approved these changes
Oct 6, 2021
| def test_sudo_kerberos_ticket(self, multihost, create_aduser_group): | ||
| """ | ||
| :title: Verify pam_sss_gss.so can handle large kerberos ticket | ||
| for sudo |
There was a problem hiding this comment.
Only one indent is required
| 8. Remove sudo cache | ||
| 9. Run sudo command again | ||
| :expectedresults: | ||
| 1. Should succeed |
| :id: 456ea53b-6702-4b8e-beb1-eee841b85fed | ||
| :bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1948657 | ||
| :steps: | ||
| 1. Add sudo rule in IPA-server for AD-users |
| (aduser, adgroup) = create_aduser_group | ||
| client = sssdTools(multihost.client[0], multihost.ad[0]) | ||
| ipaserver = sssdTools(multihost.master[0]) | ||
| cmd = 'dnf install -y sssd sssd-kcm' |
There was a problem hiding this comment.
This part is really required ?? IDM-CI will install it i think ?
| client.sssd_conf(domain_section, params) | ||
| krbkcm = '/etc/krb5.conf.d/kcm_default_ccache' | ||
| bk_krbkcm = '/tmp/kcm_default_ccache' | ||
| src = 'KCM:' |
There was a problem hiding this comment.
defined but used nowhere
| krbkcm = '/etc/krb5.conf.d/kcm_default_ccache' | ||
| bk_krbkcm = '/tmp/kcm_default_ccache' | ||
| src = 'KCM:' | ||
| dest = 'FILE:/tmp/krb5cc_%{uid}' |
There was a problem hiding this comment.
defined but used nowhere
| cmd = f'echo "{aduser} ALL=(ALL) ALL" >> /etc/sudoers' | ||
| multihost.client[0].run_command(cmd, raiseonerr=False) | ||
| try: | ||
| ssh = SSHClient(multihost.client[0].sys_hostname, |
There was a problem hiding this comment.
SSHClient not defined anywhere (Not imported )
| ssh = SSHClient(multihost.client[0].sys_hostname, | ||
| username=aduser, password='Secret123') | ||
|
|
||
| except paramiko.ssh_exception.AuthenticationException: |
There was a problem hiding this comment.
paramiko is not defined anywhere (Not imported )
aborah-sudo
requested changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verifies: #5568
Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1948657