krb5: use hidden file when creating config snippets #5825
Conversation
|
There is |
src/util/domain_info_utils.c
Outdated
| @@ -631,6 +631,28 @@ errno_t get_dom_names(TALLOC_CTX *mem_ctx, | |||
| return ret; | |||
| } | |||
|
|
|||
| char *get_hidden_tmp_path(TALLOC_CTX *mem_ctx, const char *path) | |||
| { | |||
| char *s; | |||
There was a problem hiding this comment.
[This is a "bug" in C that strrchr() returns pointer to non const char. Nonetheless,] this var can and should be declared as const char *, imo.
There was a problem hiding this comment.
Thanks, I changed it. But I think it is not a bug because it depends on the string you put into the first argument of strrchr(). If it is just a char * having char * as output is ok, since the string can be modified. I think the typical example is to split a string into 2 on a given character by replacing it with '\0'. If the strings is a const char *, as in the case here, using const char * is a good idea since you do not want to try and modify the original string.
There was a problem hiding this comment.
But if const arg is provided then function discards this const and this is a "bug".
This is a reason C++ has 2 versions:
const char* strrchr( const char* str, int ch );
char* strrchr( char* str, int ch );
But IIUC in C this function was introduced before const was available hence it wasn't possible to "fix" due to backward compatibility issues...
When creating config snippets fir libkrb5 SSSD first creates a temporary file with a random suffix and renames this file after all content is written. If this temporary file is not properly removed or renamed dur to an error it might confuse libkrb5. To avoid this confusion with this patch the temporary files are created as hidden files, the name will start with a '.', which are ignored by libkrb5. Resolves: SSSD#5824
sumit-bose
force-pushed
the
hidden_tmp_files
branch
from
ecb4a00
to
0af6545
Compare
Hi, yes, there are the POSIX bye, |
|
Thank you, ACK. |
When creating config snippets fir libkrb5 SSSD first creates a temporary
file with a random suffix and renames this file after all content is
written. If this temporary file is not properly removed or renamed dur
to an error it might confuse libkrb5.
To avoid this confusion with this patch the temporary files are created
as hidden files, the name will start with a '.', which are ignored by
libkrb5.
Resolves: #5824