AUTOFS: remove timed event if related object is removed #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autofs_map_result_timeout() is called as a timed event to free the autofs map data is the cache lifetime is exceeded. If the data is freed earlier the timed event should be removed as well to avoid a double free issue. Since talloc is used here the most easy way to achieve this is to allocate the timed event on the map object itself. Resolves: https://pagure.io/SSSD/sssd/issue/3752
|
Ack! |
|
Btw, this one would deserve a backport to another branches, right? |
|
On 31 May 2018, at 13:21, fidencio ***@***.***> wrote:
Btw, this one would deserve a backport to another branches, right?
There's no need to provide the backport patches as I can cook them later on.
I haven’t tried it but I hope the patch would either apply cleanly or the backport would be really trivial (e.g. the function is elsewhere in the same file in the older branch).
But yes, commiting to sssd-1-13 is a good idea.
|
|
master: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autofs_map_result_timeout() is called as a timed event to free the autofs
map data is the cache lifetime is exceeded. If the data is freed earlier
the timed event should be removed as well to avoid a double free issue.
Since talloc is used here the most easy way to achieve this is to allocate
the timed event on the map object itself.
Resolves: https://pagure.io/SSSD/sssd/issue/3752