Analyzer: Remove python-click dependency #5913
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalman
reviewed
Dec 14, 2021
src/tools/analyzer/sss_analyze.py
Outdated
| """ | ||
|
|
||
| class _PseudoGroup(argparse.Action): | ||
|
|
There was a problem hiding this comment.
nitpicking - Looking at the overall style this empty line should be avoided.
There was a problem hiding this comment.
Thanks, fixed - and rebased PR.
justin-stephenson
force-pushed
the
python_click_remove
branch
from
9ba686c
to
5e59fa9
Compare
|
Thank you for the patch. I will wait for CI to finish the job and then I'm going to ACK it. |
|
ACK |
Comment on lines
9
to
11
| from sss_analyze import SubparsersAction | ||
| from sss_analyze import Option | ||
| from sss_analyze import Analyzer |
There was a problem hiding this comment.
incomplete imports
see #5842
There was a problem hiding this comment.
Fixed, thank you.
As python-click will not be in RHEL9, switch to using the builtin argparse python module.
justin-stephenson
force-pushed
the
python_click_remove
branch
from
5e59fa9
to
de3635a
Compare
|
@thalman, are you fine with the latest update? @stanislavlevin, does it address your comment? |
|
@alexey-tikhonov Yes, I'm fine with last update |
|
@alexey-tikhonov, yes, it does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As python-click will not be in RHEL9, switch to using the builtin argparse python module.