Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for test bz1294670 #5933

Closed
wants to merge 2 commits into from
Closed

Fix for test bz1294670 #5933

wants to merge 2 commits into from

Conversation

dparmar18
Copy link

test_bz1294670 in src/tests/multihost/alltests/test_sudo.py had 2 problems:

  1. Wrong variable used in line 59 where there does not exist any variable named 'localuser', it should be 'user' from line 48.
  2. Wrong indentation of ssh.close() on line 66, should be aligned with the indentation of 'ssh' variable declaration on line 56.

sgoveas
sgoveas approved these changes Dec 23, 2021
View reviewed changes
Copy link
Contributor

@sgoveas sgoveas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Looks good to me.

@sgoveas sgoveas self-assigned this Dec 23, 2021
@alexey-tikhonov alexey-tikhonov added the Ready to push Ready to push label Dec 23, 2021
@alexey-tikhonov
Copy link
Member

Pushed PR: #5933

  • master
    • cf5270a - indentation of ssh.close() on line 66 corrected
    • 14c5da6 - localuser changed to user on line 59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgoveas sgoveas sgoveas approved these changes

Assignees

@sgoveas sgoveas

Labels
Pushed Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dparmar18 @alexey-tikhonov @sgoveas