krb5: add krb5_fast_use_anonymous_pkinit option #5962
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalman
requested changes
Feb 1, 2022
| if (kerr != 0) { | ||
| DEBUG(SSSDBG_CRIT_FAILURE, | ||
| "Failed to get FAST credential with anonymous PKINIT.\n"); | ||
| } |
There was a problem hiding this comment.
I'm not sure here - is it OK to continue in case of error?
| DEBUG(SSSDBG_CRIT_FAILURE, | ||
| "Failed to get FAST credential with anonymous PKINIT.\n"); | ||
| } | ||
| kerr = switch_creds(NULL, fast_uid, fast_gid, 0, NULL, &saved_creds); |
There was a problem hiding this comment.
krerr is assigned but not evaluated
sumit-bose
force-pushed
the
anonymous_pkinit
branch
from
14d146c
to
267e75a
Compare
|
Hi, thanks for the review, the latest version should fix your comments. bye, |
Make the code more flexible to add another method to get FAST credentials. Resolves: SSSD#5961
Add anonymous PKINIT as an alternative method to get FAST credentials. Resolves: SSSD#5961
With the new option krb5_fast_use_anonymous_pkinit SSSD can be told to use anonymous PKINIT to get FAST credential :relnote: Add support for anonymous PKINIT to get FAST credentials Resolves: SSSD#5961
sumit-bose
force-pushed
the
anonymous_pkinit
branch
from
267e75a
to
d451a35
Compare
|
Thank you for the update. LGTM, ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new option krb5_fast_use_anonymous_pkinit SSSD can be told to use
anonymous PKINIT to get FAST credential
:relnote: Add support for anonymous PKINIT to get FAST credentials
Resolves: #5961