sdap: record time needed for a sdap operation #5969
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the patches. Covscan is nearly clean. In general looks good to me code wise. I plan to test it once minor inline comments are resolved. |
sumit-bose
force-pushed
the
ldap_timing
branch
from
7dd60cb
to
3132778
Compare
|
Hi, thanks for the review, the latest version should cover most of your comments. bye, |
|
Thank you for the update. I still have few questions. |
sumit-bose
force-pushed
the
ldap_timing
branch
from
3132778
to
10c794e
Compare
|
This is practically ready, there is only one minor conversation left open. @sumit-bose, could you please add (or re-format existing commit message(s)) a release note? |
sumit-bose
force-pushed
the
ldap_timing
branch
from
10c794e
to
d2eb02c
Compare
SSSDBG_PERF_STAT should be use for statistical or performance data, e.g time needed for a request. :relnote: A new debug level is added to show statistical and performance data. Currently the duration of a backend request and of single LDAP operations are recorded if debug_level is set to 9 or the bit 0x20000 is set. Resolves: SSSD#5967
Two new calls get_start_time() and get_spend_time_us() are added to make it easy to calculate time differences in micro-seconds (us). Resolves: SSSD#5967
The start time of an sdap operation is stored to calculate the spend time when the operation finished. This spend time is an upper limit for the time the underlying LDAP operation took. The actual time of the LDAP operation might be shorter. This might happen is many sdap operations are running in parallel and the given operation has to wait for processing due to the asynchronous handling of the operations. Resolves: SSSD#5967
The time a backend request needs from start to finish is recorded in the logs. Resolves: SSSD#5967
Currently the IP address of the current LDAP server is only available in a log message. The new call sdap_get_server_ip_str() makes it available for other purposes as well. Resolves: SSSD#5967
Besides the LDAP message id other information might be helpful when collections statistics about LDAP operations. Resolves: SSSD#5967
Add the server IP address and other information about the current LDAP request to the timing statistics. Resolves: SSSD#5967
Add the server IPA address and other information about the current extdom LDAP extended operation to the timing statistics. Resolves: SSSD#5967
To easy identify LDAP request which are running longer than expected all requests needing 80% of there timeout are recorded wit h log level SSSDBG_IMPORTANT_INFO. The threshold of 80% is currently hard-coded. Please note that due to the asynchronous processing in the backend some requests might be logged with a long execution time not because they need the recorded time but because their processing is delayed by another request which was processed before. :relnote: A warning is added in the logs if an LDAP operation needs more than 80% of the configured timeout. Resolves: SSSD#5967
Only the msgid member of struct sdap_op is used for debugging messages in some other places of the code.
This new call is similar to sdap_get_server_ip_str() but will never return NULL so that the caller can always expect a string. sdap_get_server_ip_str() is replaced with the new call where needed. Resolves: SSSD#5967
sumit-bose
force-pushed
the
ldap_timing
branch
from
d2eb02c
to
c43a4b7
Compare
Hi, the latest version has release notes. bye, |
|
Thank you. ACK. |
|
Pushed PR: #5969
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The start time of an sdap operation is stored to calculate the spend time
when the operation finished. This spend time is an upper limit for the time
the underlying LDAP operation took. The actual time of the LDAP operation
might be shorter. This might happen is many sdap operations are running in
parallel and the given operation has to wait for processing due to the
asynchronous handling of the operations.
To easy identify LDAP request which are running longer than expected all
requests needing 80% of there timeout are recorded wit h log level
SSSDBG_IMPORTANT_INFO.
The threshold of 80% is currently hard-coded.
Please note that due to the asynchronous processing in the backend some
requests might be logged with a long execution time not because they need
the recorded time but because their processing is delayed by another
request which was processed before.
Resolves: #5967