Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ad: use right sdap_domain in ad_domain_info_send #6064

Closed
wants to merge 1 commit into from
Closed

ad: use right sdap_domain in ad_domain_info_send #6064

wants to merge 1 commit into from

Conversation

sumit-bose
Copy link
Contributor

Originally ad_domain_info_send() was only called when there was only a
single domain available and hence only a single sdap_domain struct with
the search bases in the sdap_domain list. Since ad_domain_info_send() is
now called at other times as well the right sdap_domain struct must be
selected so that the right search bases are used.

Resolves: #6063

@sumit-bose
ad: use right sdap_domain in ad_domain_info_send
783bb88 
Originally ad_domain_info_send() was only called when there was only a
single domain available and hence only a single sdap_domain struct with
the search bases in the sdap_domain list. Since ad_domain_info_send() is
now called at other times as well the right sdap_domain struct must be
selected so that the right search bases are used.

Resolves: SSSD#6063
ikerexxe
ikerexxe approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superneat solution. You even provided several test cases for sdap_domain_get_by_name(). Thanks for your hard work.

By the way, I checked it and sssd-ci/fedora34 succeeds but it's reported as a failure due to some timeout when notifying Github.

@ikerexxe ikerexxe self-assigned this Mar 21, 2022
@andreboscatto andreboscatto added the branch: sssd-1-16 Target also sssd-1-16 branch label Mar 24, 2022
@pbrezina
Copy link
Member

Thank you, ack.

@pbrezina
Copy link
Member

Pushed PR: #6064

  • master
    • 51e9229 - ad: use right sdap_domain in ad_domain_info_send
  • sssd-1-16
    • 2b84ddd - ad: use right sdap_domain in ad_domain_info_send

@pbrezina pbrezina added Pushed and removed Accepted Ready to push Ready to push labels Mar 25, 2022
@pbrezina pbrezina closed this Mar 25, 2022
@pbrezina pbrezina mentioned this pull request Mar 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikerexxe ikerexxe ikerexxe approved these changes

Assignees

@ikerexxe ikerexxe

@pbrezina pbrezina

Labels
branch: sssd-1-16 Target also sssd-1-16 branch Pushed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use right sdap_domain in ad_domain_info_send
4 participants
@sumit-bose @pbrezina @ikerexxe @andreboscatto