Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pam: fix section parsing issue #6082

Closed
wants to merge 3 commits into from

Conversation

sumit-bose
Copy link
Contributor

Due to a typo it was always necessary to have a [prompting/password]
section in sssd.conf to enable the other prompting section.

This patch fixes this and adds some unit test to cover that part of the
code.

Resolves: #6081

Copy link
Contributor

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from some minor comments everything looks good to me. I was able to test the fix and the configure prompt appears in the screen when trying to ssh.

src/tests/cmocka/test_pam_srv.c Show resolved Hide resolved
src/tests/cmocka/test_pam_srv.c Outdated Show resolved Hide resolved
src/tests/cmocka/test_pam_srv.c Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cppcheck Result

Your Best Work!

src/tests/cmocka/test_pam_srv.c Outdated Show resolved Hide resolved
src/tests/cmocka/test_pam_srv.c Show resolved Hide resolved
Copy link
Contributor

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just another note before ack'ing.

Due to a typo it was always necessary to have a `[prompting/password]`
section in sssd.conf to enable the other `prompting` section.

This patch fixes this and adds some unit test to cover that part of the
code.

Resolves: SSSD#6081
Calls to list all tests and run only a single test are added.

Resolves: SSSD#6081
Since each pam-srv-test will remove the test directory the --no-cleanup
option only makes sense if a test can be run individually.

Resolves: SSSD#6081
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cppcheck Result

What A Genius!

Copy link
Contributor

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your hard work and for all you explanations.

Copy link
Contributor

@thalman thalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the patch

@pbrezina pbrezina added the Ready to push Ready to push label Apr 6, 2022
@pbrezina
Copy link
Member

pbrezina commented Apr 6, 2022

Pushed PR: #6082

  • master
    • 5c5a6b8 - tests: allow to run single pam-srv-tests tests
    • 34829d3 - tests: add utilities for cmocka based unit tests
    • d8d2575 - pam: fix section parsing issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2FA prompting setting ineffective
4 participants