New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pam: fix section parsing issue #6082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from some minor comments everything looks good to me. I was able to test the fix and the configure prompt appears in the screen when trying to ssh.
0de25e0
to
c30dd19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cppcheck Result
Your Best Work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just another note before ack'ing.
Due to a typo it was always necessary to have a `[prompting/password]` section in sssd.conf to enable the other `prompting` section. This patch fixes this and adds some unit test to cover that part of the code. Resolves: SSSD#6081
Calls to list all tests and run only a single test are added. Resolves: SSSD#6081
Since each pam-srv-test will remove the test directory the --no-cleanup option only makes sense if a test can be run individually. Resolves: SSSD#6081
c30dd19
to
d73823c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cppcheck Result
What A Genius!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your hard work and for all you explanations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the patch
Due to a typo it was always necessary to have a
[prompting/password]
section in sssd.conf to enable the other
prompting
section.This patch fixes this and adds some unit test to cover that part of the
code.
Resolves: #6081