p11_child: enable more than one CRL PEM file #6104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ikerexxe
force-pushed
the
more_crl_files
branch
from
872dd70
to
ceebc12
Compare
|
The check failures aren't related with the changes so this PR is ready for review. |
sumit-bose
reviewed
Apr 11, 2022
|
Hi, thanks for the patch, the actual code looks good. I think I would have used a list instead of calling Please see my in-line comment about the tests. bye, |
ikerexxe
force-pushed
the
more_crl_files
branch
from
ceebc12
to
5f35d06
Compare
sumit-bose
reviewed
Apr 13, 2022
sumit-bose
reviewed
Apr 13, 2022
|
Hi, thanks, tests are looking good. I've added two inline comments and I'd like to ask you to add a bye, |
ikerexxe
force-pushed
the
more_crl_files
branch
from
5f35d06
to
2937da8
Compare
Enable support for more than one CRL PEM file. p11_child parses the crl_file list passed as argument, loads all the files and makes the validation. Finally, add a new test case in test_utils to check that the p11_child crl_file argument has been parsed correctly. Add another five test cases in test_oam_srv to check the validation process. :config: multiple crl_file arguments can be used in the certificate_verification option. Resolves: SSSD#6086 Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
ikerexxe
force-pushed
the
more_crl_files
branch
from
2937da8
to
c7b2618
Compare
|
I've added a |
sumit-bose
approved these changes
Apr 13, 2022
thalman
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable support for more than one CRL PEM file. p11_child parses the
crl_file list passed as argument, loads all the files and makes the
validation.
Finally, add a new test case in test_utils to check that the p11_child
crl_file argument has been parsed correctly. Add another three test
cases in test_oam_srv to check the validation process.
Resolves: #6086