Analyzer: Only import sssd.source_* when needed #6125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin-stephenson
approved these changes
Apr 28, 2022
|
Ack from me, just note in RH based distros we still 'Require: python3-systemd' in spec files. |
That’s OK, my motivation was fixing sss_analyze for Guix which doesn’t have systemd packaged. On RH and Debian it probably makes sense to keep the require, since they use systemd anyway. |
alexey-tikhonov
added
Waiting for review
no-backport
|
The changes look good to me but some of the tests seem to be failing. Do you mind rebasing on top of the current branch and pushing the changes again to trigger a new CI build? |
jetomit
force-pushed
the
skip-unused-imports
branch
from
2a36f07
to
3062323
Compare
This allows sss_analyze to run without python-systemd when using the Files backend.
jetomit
force-pushed
the
skip-unused-imports
branch
from
3062323
to
58fd2e0
Compare
@ikerexxe , CI is green now. |
ikerexxe
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows sss_analyze to run without python-systemd when using the Files backend.