Use negative cache better and domain checks for lookup by SIDs #6353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
aplopez
requested changes
Sep 28, 2022
|
@aplopez - thank you for the review. I updated the PR according your comments and extended tests for negative cache. T. |
sumit-bose
reviewed
Oct 3, 2022
This patch implements function to add non existing SID to negative cache for individual domains. Resolves: SSSD#6352
|
Hi, imo, commit message of a 2nd patch is a bit misleading: I mean, this is implementation of mechanism to /skip/ multi-domain search, right? |
This patch adds handlers for the dp_get_domain_check_fn(), dp_get_domain_send_fn() and dp_get_domain_recv_fn() functions to requests that resolve objects by SID. The patch also extends the AD provider so it can handle those domain-by-sid lookups. This patch also adds domain-local negcache set/check methods for SID lookups. Resolves: SSSD#6352
|
I updated the code of T. |
sumit-bose
approved these changes
Oct 4, 2022
alexey-tikhonov
approved these changes
Oct 4, 2022
Thank you for the updates. ACK. |
alexey-tikhonov
added
Accepted
Ready to push
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better use of negative cache and get_domain check mechanism for SID lookup.
The first part implements function to add non existing SID to negative
cache for an individual domains. Second part implements multi-domain search interface
for SID lookup.
Resolves: #6352