Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Add a fast, reliable, accurate ssh module #6760

Closed
wants to merge 1 commit into from
Closed

Tests: Add a fast, reliable, accurate ssh module #6760

wants to merge 1 commit into from

Conversation

aborah-sudo
Copy link
Contributor

No description provided.

@aborah-sudo aborah-sudo force-pushed the test_perpose branch 5 times, most recently from cfaa593 to a8747d3 Compare June 1, 2023 10:20
@aborah-sudo aborah-sudo force-pushed the test_perpose branch 3 times, most recently from c424fc6 to 33040d4 Compare June 1, 2023 13:19
@aborah-sudo aborah-sudo force-pushed the test_perpose branch 2 times, most recently from e32d085 to 1a98fc1 Compare June 1, 2023 14:43
@aborah-sudo aborah-sudo changed the title test only no merge Tests: Add a fast, reliable, accurate ssh module Jun 1, 2023
@aborah-sudo aborah-sudo force-pushed the test_perpose branch 4 times, most recently from c511c1a to 67707f3 Compare June 2, 2023 08:43
@aborah-sudo aborah-sudo force-pushed the test_perpose branch 2 times, most recently from c09d37d to 6097393 Compare June 5, 2023 10:39
spoore1
spoore1 reviewed Jun 5, 2023
View reviewed changes
Copy link
Contributor

@spoore1 spoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple suggestions for docstrings and changing bash code to python calls.

src/tests/multihost/alltests/test_misc.py Outdated Show resolved Hide resolved
src/tests/multihost/alltests/test_misc.py Outdated Show resolved Hide resolved
src/tests/multihost/sssd/testlib/common/expect.py Outdated Show resolved Hide resolved
src/tests/multihost/sssd/testlib/common/expect.py Outdated Show resolved Hide resolved
src/tests/multihost/sssd/testlib/common/helper_functions.py Outdated Show resolved Hide resolved
@aborah-sudo aborah-sudo force-pushed the test_perpose branch 2 times, most recently from db762dc to 47e02d9 Compare June 5, 2023 15:32
@aborah-sudo aborah-sudo requested a review from spoore1 June 5, 2023 15:43
spoore1
spoore1 reviewed Jun 6, 2023
View reviewed changes
src/tests/multihost/alltests/test_misc.py Outdated Show resolved Hide resolved
src/tests/multihost/alltests/test_misc.py Outdated Show resolved Hide resolved
src/tests/multihost/sssd/testlib/common/expect.py Outdated Show resolved Hide resolved
src/tests/multihost/sssd/testlib/common/expect.py Outdated Show resolved Hide resolved
@aborah-sudo
Copy link
Contributor Author

aborah-sudo commented Jun 15, 2023 •
edited

For Alltest:

https://ci-jenkins-csb-idmops.apps.ocp-c1.prod.psi.redhat.com/job/User-Tools/job/trigger-test-suite-tool/2807/

For IPA:

https://ci-jenkins-csb-idmops.apps.ocp-c1.prod.psi.redhat.com/job/User-Tools/job/trigger-test-suite-tool/2829/console

For AD:

https://ci-jenkins-csb-idmops.apps.ocp-c1.prod.psi.redhat.com/job/User-Tools/job/trigger-test-suite-tool/2830/console

@aborah-sudo aborah-sudo force-pushed the test_perpose branch 3 times, most recently from f72e8fc to 1971669 Compare June 16, 2023 04:51
@aborah-sudo aborah-sudo added the backport-to-stable Targets also latest stable branch label Jun 16, 2023
@aborah-sudo
Tests: Add ssh module that is fast, reliable, accurate
ff55fd0 
Sssd tests seems to be failing with current ssh module without any reason.
jakub-vavra-cz
jakub-vavra-cz requested changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use requirements.txt for installing ssh2-python otherwise looks good.

@aborah-sudo
Copy link
Contributor Author

Please use requirements.txt for installing ssh2-python otherwise looks good.

Added

jakub-vavra-cz
jakub-vavra-cz approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aborah-sudo aborah-sudo removed the request for review from shridhargadekar June 19, 2023 05:42
@jakub-vavra-cz
Copy link
Contributor

Pushed PR: #6760

  • master
    • 34dba5a - Tests: Add ssh module that is fast, reliable, accurate
  • sssd-2-7
    • af438bc - Tests: Add ssh module that is fast, reliable, accurate
  • sssd-2-8
    • 20c4472 - Tests: Add ssh module that is fast, reliable, accurate
  • sssd-2-9
    • 05bc18c - Tests: Add ssh module that is fast, reliable, accurate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spoore1 spoore1 spoore1 approved these changes

@jakub-vavra-cz jakub-vavra-cz jakub-vavra-cz approved these changes

Assignees

@spoore1 spoore1

@jakub-vavra-cz jakub-vavra-cz

Labels
backport-to-stable Targets also latest stable branch branch: sssd-2-7 branch: sssd-2-8 Pushed Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aborah-sudo @sumit-bose @jakub-vavra-cz @spoore1 @shridhargadekar