mans: fix typo in ldap_idmap_autorid_compat #6852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your branch needs to be rebased. It took some 2018 commit as its base :D |
andreboscatto
added
Waiting for review
backport-to-stable
|
@andreboscatto Please squash the commits into 1 and I'll approve 👍 |
andreboscatto
added
Rejected
Conflict
Comment wasn't relevant since 5dccf76 Reviewed-by: Alejandro Lopez <allopez@redhat.com> Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
Reviewed-by: Alejandro Lopez <allopez@redhat.com> Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
Since implementation of "local" provider was removed, the only provider that doesn't need to "check provider" is "files provider". Reviewed-by: Alejandro Lopez <allopez@redhat.com> Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
Due to CVE-2023-0286 the type of the x400Address member of the GENERAL_NAME struct was changed from ASN1_TYPE to ASN1_STRING. The following patch tries to make sure that the x400Address can be extracted from the certificate in either case. Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
When socket activated service connects for the first time, it is added to `mt_ctx->svc_list` by `socket_activated_service_not_found()` with a proper `socket_activated = true`. But when it reconnects again, `get_service_in_the_list()` finds it in `mt_ctx->svc_list` and overwrites `socket_activated = false` unconditionally. This patch moves `socket_activated = false` to `start_service()`. Resolves: SSSD#6324 Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com> Reviewed-by: Pavel Březina <pbrezina@redhat.com>
Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Sumit Bose <sbose@redhat.com>
Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com> Reviewed-by: Jakub Vávra <jvavra@redhat.com>
Reviewed-by: Jakub Vávra <jvavra@redhat.com>
https://gitlab.cee.redhat.com/sssd/sssd-qe/-/blob/RHEL8.8/client/ldap_provider/ldap_id_ldap_auth/bugzilla-automation.sh#L424 https://gitlab.cee.redhat.com/sssd/sssd-qe/-/blob/RHEL8.8/client/ldap_provider/ldap_id_ldap_auth/bugzilla-automation.sh#L300 Reviewed-by: Jakub Vávra <jvavra@redhat.com> Reviewed-by: Shridhar Gadekar <sgadekar@redhat.com>
…ntity information bz847043 https://gitlab.cee.redhat.com/sssd/sssd-qe/-/blob/RHEL9.2/client/ldap_provider/ldap_id_ldap_auth/bugzilla-automation.sh#L774 Reviewed-by: Jakub Vávra <jvavra@redhat.com> Reviewed-by: Shridhar Gadekar <sgadekar@redhat.com>
removing unused import Reviewed-by: Jakub Vávra <jvavra@redhat.com>
:feature: NSS IDMAP has two new methods: `getsidbyusername` and `getsidbygroupname` Resolves: SSSD#6565 Reviewed-by: Sumit Bose <sbose@redhat.com> Reviewed-by: Tomáš Halman <thalman@redhat.com>
Reviewed-by: Justin Stephenson <jstephen@redhat.com> Reviewed-by: Tomáš Halman <thalman@redhat.com>
…ETTINGS Reviewed-by: Alejandro López <allopez@redhat.com> Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
Reviewed-by: Alejandro López <allopez@redhat.com> Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
If the formatting option of the certificate digest/hash function contained and additional specifier separated with a '_' the comparison of the provided digest name and the available ones was incomplete, the last character was ignored and the comparison was successful if even if there was only a partial match. Resolves: SSSD#6802 Reviewed-by: Alejandro López <allopez@redhat.com> Reviewed-by: Alexey Tikhonov <atikhono@redhat.com>
Reviewed-by: Alejandro López <allopez@redhat.com> Reviewed-by: Alexey Tikhonov <atikhono@redhat.com>
correct the variable name. Signed-off-by: Madhuri Upadhye <mupadhye@redhat.com> Reviewed-by: Pavel Březina <pbrezina@redhat.com> Reviewed-by: Tomáš Halman <thalman@redhat.com>
Reviewed-by: Jakub Vávra <jvavra@redhat.com> Reviewed-by: Pavel Březina <pbrezina@redhat.com>
Fix test_maxage Reviewed-by: Shridhar Gadekar <sgadekar@redhat.com>
Fix typo in error message: "waitpid did not found" => "waitpid did not find" Signed-off-by: François Cami <fcami@redhat.com> Reviewed-by: Andre Boscatto <aboscatt@redhat.com> Reviewed-by: Justin Stephenson <jstephen@redhat.com>
Conversion of test_0001_bz1362023(), test_0002_givenmail() and test_0037_ad_parameters_extra_attrs_mail() in a system test using the new framework. Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com> Reviewed-by: Dan Lavu <dlavu@redhat.com> Reviewed-by: Pavel Březina <pbrezina@redhat.com>
duplicate backtrace is behaving differently on different versions. Moving it out of gating. Reviewed-by: Anuj Borah <aborah@redhat.com>
…verrideuser
Added automation for following bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2192708
https://bugzilla.redhat.com/show_bug.cgi?id=2196838
https://bugzilla.redhat.com/show_bug.cgi?id=2196816
https://bugzilla.redhat.com/show_bug.cgi?id=2196839
verify:
SSSD#6721
Signed-off-by: Madhuri Upadhye <mupadhye@redhat.com>
Reviewed-by: Jakub Vávra <jvavra@redhat.com>
Reviewed-by: Sumit Bose <sbose@redhat.com>
CentOS8 buildroot repo location has changed. https://lists.centos.org/pipermail/centos-devel/2023-March/142831.html Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
Fix KCM::test_client_timeout Reviewed-by: Shridhar Gadekar <sgadekar@redhat.com>
Reviewed-by: Jakub Vávra <jvavra@redhat.com> Reviewed-by: Pavel Březina <pbrezina@redhat.com>
Update sssh module for tier 1_3, 1_4 and 2 Reviewed-by: Jakub Vávra <jvavra@redhat.com> Reviewed-by: Shridhar Gadekar <sgadekar@redhat.com>
Add sleep time to test_bz785908 Reviewed-by: Shridhar Gadekar <sgadekar@redhat.com>
Add python3-libsss_nss_idmap package from utils.py Signed-off-by: Madhuri Upadhye <mupadhye@redhat.com> Reviewed-by: Jakub Vávra <jvavra@redhat.com>
This plugin adds @pytest.mark.importance("low|medium|high|critical")
and --importance=xyz cli option.
Default importance is medium.
Reviewed-by: Jakub Vávra <jvavra@redhat.com>
Reviewed-by: Tomáš Halman <thalman@redhat.com>
This plugin validates test metadata and generates Polarion import XMLs. To generate the XMLs, call pytest with: ``` --polarion-config=./polarion.yaml --output-polarion-testcase=testcase.xml --output-polarion-testrun=testrun.xml ``` Reviewed-by: Jakub Vávra <jvavra@redhat.com> Reviewed-by: Tomáš Halman <thalman@redhat.com>
Reviewed-by: Jakub Vávra <jvavra@redhat.com> Reviewed-by: Tomáš Halman <thalman@redhat.com>
It is replaced by importance marker, which defaults to medium. Reviewed-by: Jakub Vávra <jvavra@redhat.com> Reviewed-by: Tomáš Halman <thalman@redhat.com>
Number of steps did not match number of expected results. Reviewed-by: Jakub Vávra <jvavra@redhat.com> Reviewed-by: Tomáš Halman <thalman@redhat.com>
Reviewed-by: Jakub Vávra <jvavra@redhat.com> Reviewed-by: Tomáš Halman <thalman@redhat.com>
This will quickly catch issues in Polarion metadata/docstring without waiting for the test run to finish. Reviewed-by: Jakub Vávra <jvavra@redhat.com> Reviewed-by: Tomáš Halman <thalman@redhat.com>
If user_verification is enabled, then the PIN will always be requested. Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com> (cherry picked from commit b87c5a6) Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com> Reviewed-by: Sumit Bose <sbose@redhat.com>
This is more clear, and aligns with smartcard authentication verbiage. Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com> Reviewed-by: Sumit Bose <sbose@redhat.com>
local authentication methods policy - Some backends (i.e. LDAP, proxy provider) only support a password base authentication, while others can handle PKINIT based Smartcard authentication (AD, IPA), two-factor authentication (IPA), or other methods against a central instance. By default in such cases authentication is only performed with the methods supported by the backend. To allow more convenient or secure authentication methods which are supported by SSSD, but not by the backend in cases where a central authentication is not strictly required the `local_auth_policy` option is added. Ignore local auth policy when id_provider = files. Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com> Reviewed-by: Sumit Bose <sbose@redhat.com>
We can assume in this fallback chain that an empty password is not allowed. Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com> Reviewed-by: Sumit Bose <sbose@redhat.com>
…/sssd into monatomically_typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #5198
mans: fix typo in ldap_idmap_autorid_compat