sss_iface: do not add cli_id to chain key #6912
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@justin-stephenson I suppose, there was no particular reason to add cli_id to key, right? |
|
Mistype - |
alexey-tikhonov
approved these changes
Sep 4, 2023
|
Thank you, ACK. |
Otherwise we only chain identical requests from the same client which effectively renders chaining not functional. Resolves: SSSD#6911
Thanks, fixed. |
|
Ack, it was a copy/paste mistake on my part. |
justin-stephenson
approved these changes
Sep 5, 2023
alexey-tikhonov
added
Accepted
Ready to push
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we only chaing identical requests from the same client
which effectively renders chaining not functional.
Resolves: #6911
I tested this with:
But SSSD is still quite fast and only the first two-three requests
run in parallel and are chained. Other requests where served by cache.