dyndns: PTR record updates separately #6957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change LGTM, @sidecontrol I guess we have new framework tests which would cover this PR - dynamic DNS updates? |
justin-stephenson
approved these changes
Sep 26, 2023
DNS server does not allow updates for different zones in one single step. Those updates must be sent separately. It is complicated and in some cases impossible to detect that PTR updates does not fit into one zone because it often depends on DNS server configuration. With this patch PTR record updates are always sent separately. Resolves: SSSD#6956
thalman
force-pushed
the
dyndns_ptr_update
branch
from
291f489
to
44a147a
Compare
|
This force-push was fixing just typo in the title. No code-change, |
thalman
changed the title
|
@justin-stephenson yes, they still need to be ported over to the new framework. Just one thing to note, downstream, they will not cover ipv6. We had issues provisioning AD in IDMCI with ipv6 enabled on AD. |
andreboscatto
added
Accepted
backport-to-stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DNS server does not allow updates for different zones in one single step. Those updates must be sent separately.
It is complicated and in some cases impossible to detect that PTR updates does not fit into one zone because it often depends on DNS server configuration.
With this patch PTR record updates are always sent separately.
Resolves: #6956