nssidmap: fix sss_nss_getgrouplist_timeout() with empty secondary group list #7055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up list sss_nss_getgrouplist_timeout() is intended as a replacement for getgrouplist() which only gets secondary groups from SSSD. Currently it returns an ENOENT error if there are no secondary groups returned by SSSD. However, as with getgrouplist(), there is the second parameter which expects a single GID which will be added to the result. This means that sss_nss_getgrouplist_timeout() will always return at least this GID as a result and an ENOENT error does not make sense. With this patch sss_nss_getgrouplist_timeout() will not return an error anymore if there are no secondary groups but just a result with the single GID from the second parameter.
alexey-tikhonov
added
Bugzilla
backport-to-stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sss_nss_getgrouplist_timeout() is intended as a replacement for
getgrouplist() which only gets secondary groups from SSSD. Currently it
returns an ENOENT error if there are no secondary groups returned by
SSSD. However, as with getgrouplist(), there is the second parameter
which expects a single GID which will be added to the result. This means
that sss_nss_getgrouplist_timeout() will always return at least this GID
as a result and an ENOENT error does not make sense.
With this patch sss_nss_getgrouplist_timeout() will not return an error
anymore if there are no secondary groups but just a result with the
single GID from the second parameter.