Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

krb5_child: Increase child buffer and chunk size #7199

Closed
wants to merge 2 commits into from

Conversation

ikerexxe
Copy link
Contributor

@ikerexxe ikerexxe commented Feb 16, 2024

Port
9869e48
to sssd-2-8

Link: linux-pam/linux-pam@55f2064

@alexey-tikhonov
Copy link
Member

I would remove 'Passkey data can be larger than 512 bytes.' from commit message.

@alexey-tikhonov
Copy link
Member

And maybe reference pam change instead.

@alexey-tikhonov alexey-tikhonov added no-backport This should go to target branch only. Bugzilla labels Feb 16, 2024
Port
SSSD@9869e48
to sssd-2-8

Link: linux-pam/linux-pam@55f2064

Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
Reviewed-by: Sumit Bose <sbose@redhat.com>
@sumit-bose
Copy link
Contributor

Hi,

I think backporting 1f4fffd would be more important so that chunks are handled properly or is this already available in 2.8?

bye,
Sumit

@alexey-tikhonov
Copy link
Member

alexey-tikhonov commented Feb 16, 2024

I think backporting 1f4fffd would be more important so that chunks are handled properly or is this already available in 2.8?

No, it's not available.

@ikerexxe
Copy link
Contributor Author

I think backporting 1f4fffd would be more important so that chunks are handled properly or is this already available in 2.8?

No, it isn't there. It took me some time to discover that 9869e48 fixes the issue. But there are some cases that aren't covered by it and where 1f4fffd comes handy, so I'll backport the two of them.

Port
SSSD@1f4fffd
to sssd-2-8

Realloc and increase the buffer size when safe read returns more
than CHILD_MSG_CHUNK size bytes.

Reviewed-by: Alexey Tikhonov <atikhono@redhat.com>
Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
Reviewed-by: Sumit Bose <sbose@redhat.com>
@alexey-tikhonov
Copy link
Member

alexey-tikhonov commented Feb 20, 2024

@ikerexxe, looks like 9869e48 isn't in sssd-2.9 (#6628 (comment))

Please handle this that way or another (explicit PR against sssd-2.9, or split this PR into 2 and target one of them to both 2.8 and 2.9)

UPD: ah, sorry, it was before sssd-2.9 fork, so it's there.

@pbrezina pbrezina added the Ready to push Ready to push label Feb 26, 2024
@pbrezina
Copy link
Member

Pushed PR: #7199

  • sssd-2-8
    • 3332e10 - util: Realloc buffer size for atomic safe read
    • a140037 - krb5_child: Increase child buffer and chunk size

@pbrezina pbrezina added Pushed and removed Accepted Ready to push Ready to push labels Feb 26, 2024
@pbrezina pbrezina closed this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugzilla no-backport This should go to target branch only. Pushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants