New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
krb5_child: Increase child buffer and chunk size #7199
Conversation
I would remove 'Passkey data can be larger than 512 bytes.' from commit message. |
And maybe reference pam change instead. |
5e3e7d3
to
cc0585a
Compare
Port SSSD@9869e48 to sssd-2-8 Link: linux-pam/linux-pam@55f2064 Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com> Reviewed-by: Sumit Bose <sbose@redhat.com>
cc0585a
to
d681fdb
Compare
Hi, I think backporting 1f4fffd would be more important so that chunks are handled properly or is this already available in 2.8? bye, |
No, it's not available. |
No, it isn't there. It took me some time to discover that 9869e48 fixes the issue. But there are some cases that aren't covered by it and where 1f4fffd comes handy, so I'll backport the two of them. |
Port SSSD@1f4fffd to sssd-2-8 Realloc and increase the buffer size when safe read returns more than CHILD_MSG_CHUNK size bytes. Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com> Reviewed-by: Sumit Bose <sbose@redhat.com>
@ikerexxe, looks like 9869e48 isn't in sssd-2.9 (#6628 (comment)) Please handle this that way or another (explicit PR against sssd-2.9, or split this PR into 2 and target one of them to both 2.8 and 2.9) UPD: ah, sorry, it was before sssd-2.9 fork, so it's there. |
Port
9869e48
to sssd-2-8
Link: linux-pam/linux-pam@55f2064