Fix compilation build in sssd-2-8 branch #7211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
struct sdap_search_base includes the DN as a string. To better compare the DNs it is better to use a struct ldb_dn, in addition to the string. The struct ldb_dn also needs to keep the associated struct ldb_context, so we are also storing it in the structure. Resolves: SSSD#5708 Reviewed-by: Sumit Bose <sbose@redhat.com> Reviewed-by: Tomáš Halman <thalman@redhat.com> (cherry picked from commit cfc591d)
|
CC'ing @alexey-tikhonov @sumit-bose Sumit already checked that this commit doesn't have any unwanted side-effects. |
|
f-40/f-41 are failing with: due to missing 1bf5192 , but that's probably ok as we aren't going to use sssd-2.8 at those platforms... |
|
Covscan failed due to the same reason. |
|
Integration tests are failing due to some memory leak in the cares area. I don't think this is related to this change, and I wonder if I should also fix it here. |
alexey-tikhonov
approved these changes
Feb 26, 2024
Perhaps e9e6d80 is missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
04c0279 broke the compilation and porting this change will fix it.