sbus: retry Hello if ERR_SBUS_NO_REPLY was received #7312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the system is starting up it might happen that a time synchronisation daemon changes the system time. If SSSD is starting at the same time and one of the components is sending a D-Bus Hello message shortly before the time change it might happen that libdbus will consider this request as timed-out after the time change happened and returns ERR_SBUS_NO_REPLY. To avoid a complety startup failure under this condition this patch will try to send the Hello message again.
sumit-bose
force-pushed
the
sbus_hello_retry
branch
from
72201d3
to
237695d
Compare
alexey-tikhonov
added
Waiting for review
no-backport
alexey-tikhonov
approved these changes
Jun 3, 2024
|
ACK |
pbrezina
approved these changes
Jun 5, 2024
pbrezina
added
Accepted
Ready to push
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the system is starting up it might happen that a time synchronisation
daemon changes the system time. If SSSD is starting at the same time and
one of the components is sending a D-Bus Hello message shortly before
the time change it might happen that libdbus will consider this request
as timed-out after the time change happened and returns
ERR_SBUS_NO_REPLY.
To avoid a complety startup failure under this condition this patch will
try to send the Hello message again.