negcache: add fq-usernames of know domains to all UPN neg-caches #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous patch for this issue did not handle user with fully-qualified names from known domains correctly. Here the user was only added to the negative cache of the known domain but not to the negative UPN caches for all domains. This patch fixes this. Related to https://pagure.io/SSSD/sssd/issue/3978
jhrozek
approved these changes
Jun 24, 2019
|
I guess the covscan instance must have been updated because it found several potential issues I have not seen before. We should triage them eventually, but they are all in parts of code unrelated to this patch. |
This was referenced May 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous patch for this issue did not handle user with
fully-qualified names from known domains correctly. Here the user was
only added to the negative cache of the known domain but not to the
negative UPN caches for all domains. This patch fixes this.
Related to https://pagure.io/SSSD/sssd/issue/3978