ci: backport python compatibility patches to 1.16 #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did not include Lukas' patche for |
|
retest this please |
|
I must have added also one more patch: 5f2bb96 This code is no longer available in master (it is about local domain), but caused troubles with Python 3.8. |
|
retest this please |
1 similar comment
|
retest this please |
This was referenced Sep 19, 2019
Closed
|
Debain fails because PR #888 |
pbrezina
added
Ready to push
Fedora 31 changed symlink of /usr/bin/py.test from pytest2 to pytest3. We need to run the python2 version in order to run our tests with python2. Reviewed-by: Sumit Bose <sbose@redhat.com>
Reviewed-by: Sumit Bose <sbose@redhat.com>
If previous run of a PR failed to rebase, the code was left in rebase in progress and was not correctly overwritten by new changes in the patches. Reviewed-by: Tomas Halman <thalman@redhat.com>
Reviewed-by: Pavel Březina <pbrezina@redhat.com>\
Reviewed-by: Pavel Březina <pbrezina@redhat.com>\
Reviewed-by: Pavel Březina <pbrezina@redhat.com>\
Reviewed-by: Pavel Březina <pbrezina@redhat.com>\
It will simplify detection in following patches Reviewed-by: Pavel Březina <pbrezina@redhat.com>\
Reviewed-by: Pavel Březina <pbrezina@redhat.com>\
Reviewed-by: Pavel Březina <pbrezina@redhat.com>\
Samba 4.11.0 dropped support for python2 and thus it was also dropped from samba related libraries (ldb ...) which is required by integration tests Merges: https://pagure.io/SSSD/sssd/pull-request/4075 Resolves: https://pagure.io/SSSD/sssd/issue/4074 Reviewed-by: Pavel Březina <pbrezina@redhat.com>\
Samba 4.11.0 dropped support for python3 and thus it was also dropped from samba related libraries (ldb ...) which is required by integration tests Merges: https://pagure.io/SSSD/sssd/pull-request/4075 Resolves: https://pagure.io/SSSD/sssd/issue/4074 Reviewed-by: Pavel Březina <pbrezina@redhat.com>\
The macro PyDoc_STRVAR changed in python 3.8
and it defined variable with const modifier
src/python/pyhbac.c: In function ‘PyInit_pyhbac’:
src/python/pyhbac.c:1948:25: warning: passing argument 2 of
‘sss_exception_with_doc’ discards ‘const’ qualifier from pointer
target type [-Wdiscarded-qualifiers]
1948 | HbacError__doc__,
| ^~~~~~~~~~~~~~~~
In file included from src/python/pyhbac.c:27:
./src/util/sss_python.h:33:1: note: expected ‘char *’ but argument
is of type ‘const char *’
33 | sss_exception_with_doc(char *name, char *doc, PyObject *base, PyObject *dict);
| ^~~~~~~~~~~~~~~~~~~~~~
Reviewed-by: Pavel Březina <pbrezina@redhat.com>\
Reviewed-by: Pavel Březina <pbrezina@redhat.com>\
There is a warning with python 3.8 /usr/lib/python3.8/site-packages/SSSDConfig/ipachangeconf.py:399: SyntaxWarning: "is not" with a literal. Did you mean "!="? if len(sectopts) is not 0: Reviewed-by: Pavel Březina <pbrezina@redhat.com>\
Reviewed-by: Pavel Březina <pbrezina@redhat.com>\
src/tests/pysss-test.py:73: DeprecationWarning: PY_SSIZE_T_CLEAN will be required for '#' formats
val1 = obfuscator.encrypt("123", obfuscator.AES_256)
These were introduced by https://bugs.python.org/issue36381 to warn about
an upcoming Python C API change. The meaning of PY_SSIZE_T_CLEAN is described
in https://python.readthedocs.io/en/stable/c-api/arg.html#strings-and-buffers.
Reviewed-by: Pavel Březina <pbrezina@redhat.com>\
src/tests/pysss_murmur-test.py:93: DeprecationWarning: PY_SSIZE_T_CLEAN will be required for '#' formats hash_val = pysss_murmur.murmurhash3(sid_str, 0, seed) src/tests/pysss_murmur-test.py:96: DeprecationWarning: PY_SSIZE_T_CLEAN will be required for '#' formats hash_val = pysss_murmur.murmurhash3(sid_str, len(sid_str), seed) These were introduced by https://bugs.python.org/issue36381 to warn about an upcoming Python C API change. The meaning of PY_SSIZE_T_CLEAN is described in https://python.readthedocs.io/en/stable/c-api/arg.html#strings-and-buffers. Reviewed-by: Pavel Březina <pbrezina@redhat.com>\
Reviewed-by: Pavel Březina <pbrezina@redhat.com>\
To fix this error that happened during mockbuild on rawhide. FAIL: src/tests/pysss-test.py3 ============================== ERROR: test_import (__main__.PysssImport) Import the module and assert it comes from tree ---------------------------------------------------------------------- Traceback (most recent call last): File "/builddir/build/BUILD/sssd-1.16.5/src/tests/pysss-test.py", line 56, in test_import import pysss SystemError: bad call flags In Python 3.7, import didn't check descriptor flags (METH_KEYWORDS): these flags were only checked when the methods were called. In Python 3.8, the flags are checked as soon as the module is imported, which prevents the module to be imported. Inspired by: rpm-software-management/libcomps#50 Python doc: https://docs.python.org/3/c-api/structures.html#METH_VARARGS
|
Rebased on top of current sssd-1-16. There was a conflict solved by 3way merge. I'll wait till the CI finish then push. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.