Fix memory leak about krb5 error message #931
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krb5 error message obtained with sss_krb5_get_error_message() must be released with sss_krb5_free_error_message(). It is not released in some message output processes. Added error message release processing.
|
Can one of the admins verify this patch? |
|
Is this duplicate with PR#915? |
Hi, thank you for your patch, but yes, there is an overlap with PR#915. I have not checked it line-by-line and I would suggest that I'll do the review of PR#915 then it would be easier to see if your patch covers parts which are not handled by PR#915. bye, |
|
Hi, @alexey-tikhonov san PR#915 includes all of PR#931. Thank you for your cooperation. |
|
Thank you for confirming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
krb5 error message obtained with sss_krb5_get_error_message() must be released with sss_krb5_free_error_message().
It is not released in some message output processes.
Added error message release processing.