Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💚 PR check - Pagespeed insights fails on first run #785

Closed
3 tasks done
bradystroud opened this issue Jun 11, 2023 · 2 comments · Fixed by #831
Closed
3 tasks done

💚 PR check - Pagespeed insights fails on first run #785

bradystroud opened this issue Jun 11, 2023 · 2 comments · Fixed by #831
Assignees

Comments

@bradystroud
Copy link
Member

bradystroud commented Jun 11, 2023

The PageSpeed insights PR check fails on its first run.

I think this is because its needs the PR environment to be deployed, and there is a short period after the deploy has completed but
the site is not actually live.

Tasks


Figure: PageSpeed Insights failing

@amankumarrr amankumarrr self-assigned this Jun 14, 2023
@amankumarrr
Copy link
Member

@bradystroud @wicksipedia

Hi Team,

After a thorough investigation, we have identified the root cause to be intermittent issues with URL accessibility with the actual GitHub flow.
To fix this issue I have introduced the following features to the flow.

Features:

  • Improved Reliability: To mitigate the intermittent URL accessibility issues, the workflow has been enhanced to make two additional attempts if the first attempt fails. This improves the overall reliability of the workflow.

  • Robust Flow: In case of failure, the workflow has been modified to gracefully handle the situation without breaking the overall flow. This ensures smoother PR processing even when issues arise.

  • Enhanced Feedback: To provide clearer feedback, error, and success messages have been enhanced with emojis. This visual representation makes it easier to identify the status of the workflow at a glance.

Screenshot

PageInsight Change

Figure: Tested on your forked repo, showing error on the first instance, and ran successfully on the second attempt

Here is its PR : wicksipedia/pagespeed-insights#41

@amankumarrr
Copy link
Member

@bradystroud @wicksipedia

This PR wicksipedia/pagespeed-insights#41 has been merged with his main and I have tested it on our pipeline, seems like working fine now, therefore, I'm closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
2 participants