-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR Push Deploy - Adding delay before page insight #807
Conversation
Deployed changes to https://app-sswwebsite-9eb3-pr-807.azurewebsites.net |
Deployed changes to https://app-sswwebsite-9eb3-pr-807.azurewebsites.net |
Deployed changes to https://app-sswwebsite-9eb3-pr-807.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-807.azurewebsites.net |
Deployed changes to https://app-sswwebsite-9eb3-pr-807.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-807.azurewebsites.net |
Deployed changes to https://app-sswwebsite-9eb3-pr-807.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-807.azurewebsites.net |
Deployed changes to https://app-sswwebsite-9eb3-pr-807.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-807.azurewebsites.net |
Deployed changes to https://app-sswwebsite-9eb3-pr-807.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-807.azurewebsites.net |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @amankumarrr, well done on the fix! 🎉
Here are a couple of things I noticed:
- The delay part in the code could use a comment. It'll help others understand why it's there. 🤔👀
- A bit more description in the PR would make it easier to review. 👁️📝
Cheers! 👍🙂
Deployed changes to https://app-sswwebsite-9eb3-pr-807.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-807.azurewebsites.net |
Deployed changes to https://app-sswwebsite-9eb3-pr-807.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-807.azurewebsites.net |
Deployed changes to https://app-sswwebsite-9eb3-pr-807.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-807.azurewebsites.net |
Deployed changes to https://app-sswwebsite-9eb3-pr-807.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-807.azurewebsites.net |
Fixes #785