Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Push Deploy - Adding delay before page insight #807

Closed
wants to merge 4 commits into from
Closed

Conversation

amankumarrr
Copy link
Member

Fixes #785

@github-actions
Copy link

Deployed changes to https://app-sswwebsite-9eb3-pr-807.azurewebsites.net

@github-actions
Copy link

Deployed changes to https://app-sswwebsite-9eb3-pr-807.azurewebsites.net

@github-actions
Copy link

Deployed changes to https://app-sswwebsite-9eb3-pr-807.azurewebsites.net

@github-actions
Copy link

PageSpeed Insights

Category Score
Accessibility 89
Best practices 92
Performance 61
SEO 100

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-807.azurewebsites.net

@github-actions
Copy link

Deployed changes to https://app-sswwebsite-9eb3-pr-807.azurewebsites.net

@github-actions
Copy link

PageSpeed Insights

Category Score
Accessibility 89
Best practices 92
Performance 83
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-807.azurewebsites.net

@github-actions
Copy link

Deployed changes to https://app-sswwebsite-9eb3-pr-807.azurewebsites.net

@github-actions
Copy link

PageSpeed Insights

Category Score
Accessibility 89
Best practices 83
Performance 60
SEO 100

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-807.azurewebsites.net

@github-actions
Copy link

Deployed changes to https://app-sswwebsite-9eb3-pr-807.azurewebsites.net

@github-actions
Copy link

PageSpeed Insights

Category Score
Accessibility 89
Best practices 92
Performance 60
SEO 100

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-807.azurewebsites.net

@github-actions
Copy link

Deployed changes to https://app-sswwebsite-9eb3-pr-807.azurewebsites.net

@github-actions
Copy link

PageSpeed Insights

Category Score
Accessibility 89
Best practices 83
Performance 53
SEO 100

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-807.azurewebsites.net

Copy link
Member

@bradystroud bradystroud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @amankumarrr, well done on the fix! 🎉

Here are a couple of things I noticed:

  1. The delay part in the code could use a comment. It'll help others understand why it's there. 🤔👀
  2. A bit more description in the PR would make it easier to review. 👁️📝

Cheers! 👍🙂

@github-actions
Copy link

Deployed changes to https://app-sswwebsite-9eb3-pr-807.azurewebsites.net

@github-actions
Copy link

PageSpeed Insights

Category Score
Accessibility 89
Best practices 83
Performance 54
SEO 100

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-807.azurewebsites.net

@github-actions
Copy link

Deployed changes to https://app-sswwebsite-9eb3-pr-807.azurewebsites.net

@github-actions
Copy link

PageSpeed Insights

Category Score
Accessibility 89
Best practices 83
Performance 61
SEO 100

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-807.azurewebsites.net

@github-actions
Copy link

Deployed changes to https://app-sswwebsite-9eb3-pr-807.azurewebsites.net

@github-actions
Copy link

PageSpeed Insights

Category Score
Accessibility 89
Best practices 92
Performance 61
SEO 100

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-807.azurewebsites.net

@github-actions
Copy link

Deployed changes to https://app-sswwebsite-9eb3-pr-807.azurewebsites.net

@github-actions
Copy link

PageSpeed Insights

Category Score
Accessibility 89
Best practices 92
Performance 53
SEO 100

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-807.azurewebsites.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💚 PR check - Pagespeed insights fails on first run
2 participants