Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› Bug - Fix Hydration Errors From Megamenu + SocialIcons #2400

Merged
merged 3 commits into from Apr 2, 2024

Conversation

Harry-Ross
Copy link
Contributor

@Harry-Ross Harry-Ross commented Apr 2, 2024

  • Upgrade megamenu to 4.5.4 - has fix for hydration
  • Added isMobile fixes on SocialIcons
  • Added fix for key prop problem with SocialIcons

image
❌ Figure: Before - Hydration errors on production

image
βœ… Figure: After - No hydration errors on PR deployment

@Harry-Ross Harry-Ross changed the title fixed socialicons issue with isMobile πŸ› Bug - Fix Hydration Errors From Megamenu + SocialIcons Apr 2, 2024
Copy link

github-actions bot commented Apr 2, 2024

Coverage report

St.❔
Category Percentage Covered / Total
πŸ”΄ Statements 0.25% 69/27657
πŸ”΄ Branches 8.86% 24/271
πŸ”΄ Functions 1.2% 3/250
πŸ”΄ Lines 0.25% 69/27657

Test suite run success

13 tests passing in 1 suite.

Report generated by πŸ§ͺjest coverage report action from c066cd0

Copy link

github-actions bot commented Apr 2, 2024

Deployed changes to https://app-sswwebsite-9eb3-pr-2400.azurewebsites.net

Copy link

github-actions bot commented Apr 2, 2024

PageSpeed Insights

Category Score
Accessibility 90
Best practices 100
Performance 50
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2400.azurewebsites.net

Copy link
Member

@amankumarrr amankumarrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Harry-Ross Harry-Ross merged commit e658f83 into main Apr 2, 2024
11 checks passed
@Harry-Ross Harry-Ross deleted the 2386-hydration-errors branch April 2, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⚠️ Megamenu - hydration errors are causing lighthouse scores to tank
2 participants