[Implement] SonarQube improvements

STARIONGROUP · May 14, 2024 · e1ce195 · e1ce195
1 parent 232410b
commit e1ce195
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/ReqIFSharp.Extensions.Tests/ReqIFExtensions/SpecElementWithAttributesExtensionTestFixture.cs b/ReqIFSharp.Extensions.Tests/ReqIFExtensions/SpecElementWithAttributesExtensionTestFixture.cs
@@ -39,7 +39,7 @@ public class SpecElementWithAttributesExtensionTestFixture
     {
         private ReqIF reqIf;
 
-        private IReqIFLoaderService reqIFLoaderService;
+        private ReqIFLoaderService reqIFLoaderService;
 
         [SetUp]
         public async Task SetUp()

diff --git a/ReqIFSharp.Extensions/ReqIFExtensions/SpecElementWithAttributesExtensions.cs b/ReqIFSharp.Extensions/ReqIFExtensions/SpecElementWithAttributesExtensions.cs
@@ -69,14 +69,15 @@ public static IEnumerable<ExternalObject> QueryExternalObjects(this SpecElementW
         {
             var result = new List<Tuple<ExternalObject, string>>();
 
-            var cts = new CancellationTokenSource();
-
-            foreach (var specObjectValue in specElementWithAttributes.Values.OfType<AttributeValueXHTML>())
+            using (var cts = new CancellationTokenSource())
             {
-                foreach (var externalObject in specObjectValue.ExternalObjects)
+                foreach (var specObjectValue in specElementWithAttributes.Values.OfType<AttributeValueXHTML>())
                 {
-                    var payload = await reqIfLoaderService.QueryData(externalObject, cts.Token);
-                    result.Add(new Tuple<ExternalObject, string>(externalObject, payload));
+                    foreach (var externalObject in specObjectValue.ExternalObjects)
+                    {
+                        var payload = await reqIfLoaderService.QueryData(externalObject, cts.Token);
+                        result.Add(new Tuple<ExternalObject, string>(externalObject, payload));
+                    }
                 }
             }