Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous Updates for rest_config.yml #1

Closed
JoelProminic opened this issue Jan 26, 2024 · 4 comments
Closed

Miscellaneous Updates for rest_config.yml #1

JoelProminic opened this issue Jan 26, 2024 · 4 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@JoelProminic
Copy link
Collaborator

We have some pending tasks in Moonshine-IDE (#1240, #1241) that will require new scripts and capabilities for the REST-Interface.

As part of this work, I revisited the configuration file (`hcl_domino_vagrant_rest_api/templates/rest_config.yml.j2) and found some changes I would like to make:

  • Add the Domino version number at restinterface.dominoVersion)
  • serverName is hard-coded for now. This should use the actual server name (watch for the server name discrepancy between Domino 12.0.1 and Domino 12.0.2).
  • Revisit baseURL - I think 127.0.0.1 should be replaced with a subdomain instead
@JoelProminic JoelProminic added bug Something isn't working enhancement New feature or request labels Jan 26, 2024
@JoelProminic JoelProminic self-assigned this Jan 26, 2024
@JoelProminic
Copy link
Collaborator Author

I found this issue which clarified that baseURL should look like https://domino.%FQDN% (i.e. https://domino.demo.startcloud.com). This determines the base URL after deploying an HTML application to the Domino server.

@JoelProminic
Copy link
Collaborator Author

I started making updates for this but I found that /info only returns the capabilities from this file:

{
  "status": "ready",
  "capabilities": [
    "upload-database",
    "upload-html",
    "java-domino-gradle",
    "nsfodp"
  ]
}

This should be easy to update here. However, I'd like to make this generic so that I don't need to keep updating the Vagrant-REST-API each time I want to add another property. Some ideas:

  • Copy all properties from restinterface:
  • Create a new section like restinterface.serverInfo or restinterface.domino and copy all entries from that

@JoelProminic
Copy link
Collaborator Author

I tested with both Domino 12.0.1 and 12.0.2 to make sure that serverName and dominoVersion were populated correctly:

12.0.1:

{
  "status": "ready",
  "capabilities": [
    "upload-database",
    "upload-html",
    "java-domino-gradle",
    "nsfodp",
    "import-domino-json"
  ],
  "serverInfo": {
    "dominoVersion": "12.1.1",
    "serverName": "test-rest-018/TEST018",
    "baseURL": "https://domino.test-rest-018.shi.com"
  }
}

12.0.2:

{
  "status": "ready",
  "capabilities": [
    "upload-database",
    "upload-html",
    "java-domino-gradle",
    "nsfodp",
    "import-domino-json"
  ],
  "serverInfo": {
    "dominoVersion": "12.2.2",
    "serverName": "test-rest-018.shi.com/TEST018",
    "baseURL": "https://domino.test-rest-018.shi.com"
  }
}

Note that there is a problem with the domino_minor_version. This seems to be a bug in SHI Dev v0.10.1, which I'll report separately.

@piotrzarzycki21
Copy link
Collaborator

If version is incorrectly reported in hosts.yml file I think I have fixed that while work on update in SHI to provisioner 0.1.23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants