Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cool_down option to the plan. #134

Merged
merged 11 commits into from
Aug 20, 2023
Merged

feat: add cool_down option to the plan. #134

merged 11 commits into from
Aug 20, 2023

Conversation

Ari-suhyeon
Copy link
Contributor

@Ari-suhyeon Ari-suhyeon commented Aug 18, 2023 •
edited by pueding
Loading

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • DevOps process (non-breaking change which improves efficiency and reliability for CI/CD)
  • Documentation only

What this PR does / why we need it:

  • Add metadata.cool_down to the ScalingComponentDefinition ScalingPlanDefinition.
  • remove code to verify that the plan has already been executed
  • Move interval and title under metadata.

Which issue/s this PR fixes

fixes #124

How Has This Been Tested?

  • Unit Test has been tested.
  • metric simulation tested.

Checklist:

@Ari-suhyeon
feat(data-layer): add ScalingPlanDefinition.metadata
8425b4e
@Ari-suhyeon
feat(wave-autoscale): add last_plan_timestamp and added cool down to …
cd6cbd0 
…operate when the plan starts.
@Ari-suhyeon
fix(data-layer): test yaml update - add ScalingPlan metadata
c6868bb
@Ari-suhyeon
fix(wave-autoscale): update mut Option<DateTime<Utc>> to Arc<RwLock<O…
b7c5743 
…ption<DateTime<Utc>>>> for last_plan_timestamp
@Ari-suhyeon
remove(wave-autoscale): remove code to verify that the plan has alrea…
cc68d61 
…dy been executed
@Ari-suhyeon
fix(data-layer): ScalingPlan move interval and title under metadata.
5b36699
@Ari-suhyeon
test(wave-autoscale): add test_last_plan_timestamp
6e2b30d
@Ari-suhyeon
Merge branch 'main' of https://github.com/STCLab-Inc/wave-autoscale i…
9f44757 
…nto 124-cool-down
@Ari-suhyeon
Merge branch 'main' of https://github.com/STCLab-Inc/wave-autoscale i…
6601c45 
…nto 124-cool-down
@Ari-suhyeon
refactor(wave-autoscale): continue was removed when cool_down is not …
9f3b950 
…a number.
@Ari-suhyeon Ari-suhyeon added type: new-feature type: New feature or request target: plan labels Aug 18, 2023
@Ari-suhyeon Ari-suhyeon added this to the v0.0.12 milestone Aug 18, 2023
@Ari-suhyeon Ari-suhyeon linked an issue Aug 18, 2023 that may be closed by this pull request
Cool down #124
Closed
pueding
pueding requested changes Aug 18, 2023
View reviewed changes
core/wave-autoscale/src/scaling_planner/mod.rs Outdated Show resolved Hide resolved
core/wave-autoscale/src/scaling_planner/mod.rs Outdated Show resolved Hide resolved
core/wave-autoscale/src/scaling_planner/mod.rs Outdated Show resolved Hide resolved
@pueding pueding merged commit 7169328 into main Aug 20, 2023
1 check passed
@pueding pueding deleted the 124-cool-down branch August 20, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pueding pueding pueding approved these changes

Assignees
No one assigned
Labels
target: plan type: new-feature type: New feature or request
Projects
None yet
Milestone
v0.0.12
Development

Successfully merging this pull request may close these issues.

Cool down
2 participants
@Ari-suhyeon @pueding