Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: component target value change to js expression and add variable #155

Merged
merged 9 commits into from
Sep 15, 2023
Merged

feature: component target value change to js expression and add variable #155

merged 9 commits into from
Sep 15, 2023

Conversation

Ari-suhyeon
Copy link
Contributor

@Ari-suhyeon Ari-suhyeon commented Sep 14, 2023 •
edited
Loading

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • DevOps process (non-breaking change which improves efficiency and reliability for CI/CD)
  • Documentation only

What this PR does / why we need it:

  • component target value change to JS Expression and add variable
  • current state value
    • AWS EC2 Component
      • desired
      • min
      • max
    • AWS EKS Component
      • replicas
      • unavailable_replicas
      • available_replicas
      • ready_replicas
      • updated_replicas

Which issue/s this PR fixes

fixes #154

How Has This Been Tested?

  • moon run tested - EC2
  • Unit Test has been tested. - EC2, EKS

Checklist:

@Ari-suhyeon Ari-suhyeon added this to the v0.0.13 milestone Sep 14, 2023
@Ari-suhyeon Ari-suhyeon self-assigned this Sep 14, 2023
@Ari-suhyeon Ari-suhyeon linked an issue Sep 14, 2023 that may be closed by this pull request
component target value change to JS Expression and add variable #154
Closed
@pueding pueding merged commit 3c6d8c1 into main Sep 15, 2023
1 check passed
@pueding pueding deleted the 154-component-target-value-change-to-js-expression-and-add-variable branch September 15, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pueding pueding pueding approved these changes

Assignees

@Ari-suhyeon Ari-suhyeon

Labels
target: plan
Projects
None yet
Milestone
v0.0.13
Development

Successfully merging this pull request may close these issues.

component target value change to JS Expression and add variable
2 participants
@Ari-suhyeon @pueding