Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Refactor the metrics logic #187

Merged
merged 8 commits into from
Oct 25, 2023
Merged

feat: Refactor the metrics logic #187

merged 8 commits into from
Oct 25, 2023

Conversation

pueding
Copy link
Member

@pueding pueding commented Oct 25, 2023

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • DevOps process (non-breaking change which improves efficiency and reliability for CI/CD)
  • Documentation only

What this PR does / why we need it:

  • Skip some logic when there is no metric to handle
  • Change some info logs
  • Add "reset_definitions_on_startup" in wave-config

Which issue/s this PR fixes

#186

How Has This Been Tested?

Checklist:

@pueding pueding added this to the v0.0.15 milestone Oct 25, 2023
@pueding pueding linked an issue Oct 25, 2023 that may be closed by this pull request
Refactor converting metric definitions #186
Closed
@pueding pueding merged commit 8202d16 into main Oct 25, 2023
1 check passed
@pueding pueding deleted the 186-refactor-converting-metric-definitions branch October 25, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.0.15
Development

Successfully merging this pull request may close these issues.

Refactor converting metric definitions
1 participant
@pueding