Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update for kubernetes merge patch to json patch #197

Merged
merged 4 commits into from
Nov 6, 2023
Merged

feat: update for kubernetes merge patch to json patch #197

merged 4 commits into from
Nov 6, 2023

Conversation

Ari-suhyeon
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • DevOps process (non-breaking change which improves efficiency and reliability for CI/CD)
  • Documentation only

What this PR does / why we need it:

update for kubernetes merge patch to json patch

  • If you use remove patch, you may experience errors in autoscaling_history.
  • use add null for value
    ex)
- op: add
   path: /spec/http/0/fault
   value: null

Which issue/s this PR fixes

fixes #194

How Has This Been Tested?

  • moon run tested - check the scaling component works

Checklist:

@Ari-suhyeon Ari-suhyeon added this to the v0.1.0 milestone Nov 6, 2023
@Ari-suhyeon Ari-suhyeon self-assigned this Nov 6, 2023
@Ari-suhyeon Ari-suhyeon linked an issue Nov 6, 2023 that may be closed by this pull request
update for kubernetes merge patch to json patch #194
Closed
pueding
pueding approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@pueding pueding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@pueding pueding merged commit 5e3deda into main Nov 6, 2023
1 check passed
@pueding pueding deleted the 194-update-for-kubernetes-merge-patch-to-json-patch branch November 6, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pueding pueding pueding approved these changes

Assignees

@Ari-suhyeon Ari-suhyeon

Labels
target: scaling-component target:
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.

update for kubernetes merge patch to json patch
2 participants
@Ari-suhyeon @pueding