Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(data-layer): Add date information in getting metrics, scaling-co… #216

Merged
merged 2 commits into from
Dec 8, 2023
Merged

feat(data-layer): Add date information in getting metrics, scaling-co… #216

merged 2 commits into from
Dec 8, 2023

Conversation

bryan-stclab
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • DevOps process (non-breaking change which improves efficiency and reliability for CI/CD)
  • Documentation only

What this PR does / why we need it:

Which issue/s this PR fixes

#215

How Has This Been Tested?

Checklist:

@bryan-stclab bryan-stclab added type: new-feature type: New feature or request target: data-layer labels Dec 7, 2023
@bryan-stclab bryan-stclab added this to the v0.1.0 milestone Dec 7, 2023
@bryan-stclab bryan-stclab self-assigned this Dec 7, 2023
@bryan-stclab bryan-stclab linked an issue Dec 7, 2023 that may be closed by this pull request
Add date information to /api/metrics, /api/scaling-components, and /api/plans #215
Closed
pueding
pueding requested changes Dec 7, 2023
View reviewed changes
Copy link
Member

@pueding pueding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it needs to confirm whether created_at and updated_at are valid in test cases

@bryan-stclab
feat(data-layer): Add test codes to check the date information and le…
7969fcb 
…ngth in metrics, scaling-components, and plans apis
@pueding pueding merged commit 4206cef into main Dec 8, 2023
1 check passed
@pueding pueding deleted the 215-add-date-information-to-apimetrics-apiscaling-components-and-apiplans branch December 8, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pueding pueding pueding approved these changes

Assignees

@bryan-stclab bryan-stclab

Labels
target: data-layer type: new-feature type: New feature or request
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.

Add date information to /api/metrics, /api/scaling-components, and /api/plans
2 participants
@bryan-stclab @pueding