add webhooks function (Http, SlackIncomingWebhook) #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ari-suhyeon
added
type: new-feature
pueding
requested changes
Feb 28, 2024
core/utils/src/wave_config.rs
Outdated
| #[serde(default = "default_webhooks_headers")] | ||
| pub headers: Option<HashMap<String, String>>, | ||
| #[serde(default = "default_webhooks_webhook_url")] | ||
| pub webhook_url: Option<String>, |
| #[derive(PartialEq, Clone, Deserialize, Debug)] | ||
| pub struct Webhooks { | ||
| pub id: String, | ||
| pub webhook_type: WebhookType, |
There was a problem hiding this comment.
ignore the upper or the lower cases
core/wave-autoscale/src/app.rs
Outdated
| pub async fn new( | ||
| wave_config: WaveConfig, | ||
| shared_data_layer: Arc<DataLayer>, | ||
| webhooks: Option<Vec<utils::wave_config::Webhooks>>, |
There was a problem hiding this comment.
remove the webhooks and reuse the wave_config
core/wave-autoscale/src/main.rs
Outdated
| let mut app = app::App::new( | ||
| wave_config.clone(), | ||
| shared_data_layer.clone(), | ||
| wave_config.webhooks.clone(), |
| })) | ||
| } | ||
|
|
||
| pub fn response_for_slack(&self) -> Option<serde_json::Value> { |
| pub fail_message: Option<String>, | ||
| } | ||
| impl WebhookResponse { | ||
| pub fn response_for_http(&self) -> Option<serde_json::Value> { |
| use utils::wave_config::Webhooks; | ||
|
|
||
| #[derive(Clone)] | ||
| pub struct WebhookResponse { |
There was a problem hiding this comment.
WebhookResponse => WebhookRequestBody
| } | ||
| } | ||
|
|
||
| pub enum WebhookResponseStatus { |
pueding
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Which issue/s this PR fixes (#)
#239
How Has This Been Tested?