Skip to content

Commit

Permalink
Ensure TCP parcelport is deactivated if not needed
Browse files Browse the repository at this point in the history
  • Loading branch information
hkaiser committed May 18, 2024
1 parent 20cb916 commit 132d919
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
1 change: 1 addition & 0 deletions docs/sphinx/releases/whats_new_1_10_0.rst
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ Closed pull requests

* :hpx-pr:`6491` - More fixes to handling bool arguments for collective operations
* :hpx-pr:`6490` - Remove the default max cpu count
* :hpx-pr:`6489` - Ensure TCP parcelport is deactivated if not needed
* :hpx-pr:`6488` - Fixing handling of bool value type for collective operations
* :hpx-pr:`6485` - Destructive interference size
* :hpx-pr:`6484` - Improve performance counter error handling
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ namespace hpx::util {
node != static_cast<std::size_t>(-1) && vm.count("hpx:debug-clp");

// create host name mapping
[[maybe_unused]] bool const have_tcp =
[[maybe_unused]] bool have_tcp =
rtcfg_.get_entry("hpx.parcel.tcp.enable", "1") != "0";
util::map_hostnames mapnames(debug_clp);

Expand Down Expand Up @@ -550,9 +550,14 @@ namespace hpx::util {
run_agas_server = vm.count("hpx:run-agas-server") != 0;
if (node == static_cast<std::size_t>(-1))
node = env.retrieve_node_number();

// make sure that TCP parcelport will only be enabled if necessary
if (num_localities_ == 1 && !expect_connections)
have_tcp = false;
#else
num_localities_ = 1;
node = 0;
have_tcp = false;
#endif

// If the user has not specified an explicit runtime mode we retrieve it
Expand Down

0 comments on commit 132d919

Please sign in to comment.