Skip to content

Commit

Permalink
Guided task spawn was using the wrong hint constructor (missing numa …
Browse files Browse the repository at this point in the history
…domain)
  • Loading branch information
biddisco committed Nov 8, 2018
1 parent d171765 commit 9acb734
Showing 1 changed file with 14 additions and 8 deletions.
22 changes: 14 additions & 8 deletions hpx/runtime/threads/executors/guided_pool_executor.hpp
Expand Up @@ -121,14 +121,16 @@ namespace hpx { namespace threads { namespace executors
hpx::launch::sync,
executor_.get_priority(),
executor_.get_stacksize(),
threads::thread_schedule_hint(domain));
threads::thread_schedule_hint(
thread_schedule_hint_mode_numa, domain));
}
else {
p.apply(
hpx::launch::async,
executor_.get_priority(),
executor_.get_stacksize(),
threads::thread_schedule_hint(domain));
threads::thread_schedule_hint(
thread_schedule_hint_mode_numa, domain));
}

return p.get_future();
Expand Down Expand Up @@ -181,14 +183,16 @@ namespace hpx { namespace threads { namespace executors
hpx::launch::sync,
executor_.get_priority(),
executor_.get_stacksize(),
threads::thread_schedule_hint(domain));
threads::thread_schedule_hint(
thread_schedule_hint_mode_numa, domain));
}
else {
p.apply(
hpx::launch::async,
executor_.get_priority(),
executor_.get_stacksize(),
threads::thread_schedule_hint(domain));
threads::thread_schedule_hint(
thread_schedule_hint_mode_numa, domain));
}

return p.get_future();
Expand Down Expand Up @@ -248,8 +252,8 @@ namespace hpx { namespace threads { namespace executors
<< util::debug::print_type<result_type>() << "\n"
<< "async_execute : Numa Hint : "
<< util::debug::print_type<pool_numa_hint<Tag>>() << "\n"
<< "async_execute : Hint : "
<< util::debug::print_type<H>() << "\n";
/* << "async_execute : Hint : "
<< util::debug::print_type<H>() << "\n"*/;
#endif

// hold onto the function until all futures have become ready
Expand Down Expand Up @@ -457,14 +461,16 @@ namespace hpx { namespace threads { namespace executors
hpx::launch::sync,
pool_executor_.get_priority(),
pool_executor_.get_stacksize(),
threads::thread_schedule_hint(domain));
threads::thread_schedule_hint(
thread_schedule_hint_mode_numa, domain));
}
else {
p.apply(
hpx::launch::async,
pool_executor_.get_priority(),
pool_executor_.get_stacksize(),
threads::thread_schedule_hint(domain));
threads::thread_schedule_hint(
thread_schedule_hint_mode_numa, domain));
}
return p.get_future();
}
Expand Down

0 comments on commit 9acb734

Please sign in to comment.