Variadic templates support for runtime_support and components #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please readd the action_serialization_data constructors. |
|
transfer_action is tuplyfied again. |
|
I think the PR needs to be brought in line with latest master first. |
|
Rebased, with no conflicts. Running tests again. |
|
functional::new_ is a little confusing. I was expecting it to call components::new_, not regular new. What do others think? |
|
Looks good otherwise! |
Letting it call the API instead of an internal function is the right thing to do, I believe. |
K-ballo
changed the title
K-ballo
added a commit
that referenced
this pull request
Jan 23, 2015
Variadic templates support for runtime_support and components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variadic templates support for runtime_support and components.