Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master branch does not build with idle rate counters enabled #3836

Closed
biddisco opened this issue May 5, 2019 · 3 comments · Fixed by #3837
Closed

master branch does not build with idle rate counters enabled #3836

biddisco opened this issue May 5, 2019 · 3 comments · Fixed by #3837

Comments

@biddisco
Copy link
Contributor

biddisco commented May 5, 2019

Use

HPX_WITH_THREAD_IDLE_RATES=ON

Error

[  0%] Built target hpx_wrap
[  0%] Built target hpx_preprocessor
[  0%] Built target hpx_init
[ 10%] Building CXX object src/CMakeFiles/hpx.dir/runtime/threads/detail/scheduled_thread_pool.cpp.o
[ 10%] Building CXX object src/CMakeFiles/hpx.dir/runtime/threads/thread.cpp.o
[ 20%] Building CXX object src/CMakeFiles/hpx.dir/runtime/threads/thread_data.cpp.o
[ 20%] Building CXX object src/CMakeFiles/hpx.dir/runtime/threads/thread_helpers.cpp.o
[ 20%] Building CXX object src/CMakeFiles/hpx.dir/runtime/threads/thread_executor.cpp.o
[ 20%] Building CXX object src/CMakeFiles/hpx.dir/runtime/threads/thread_pool_base.cpp.o
[ 20%] Building CXX object src/CMakeFiles/hpx.dir/runtime/threads/threadmanager.cpp.o
[ 20%] Building CXX object src/CMakeFiles/hpx.dir/runtime/threads/topology.cpp.o
[ 20%] Building CXX object src/CMakeFiles/hpx.dir/runtime/trigger_lco.cpp.o
[ 20%] Building CXX object src/CMakeFiles/hpx.dir/performance_counters/counter_creators.cpp.o
[ 20%] Building CXX object src/CMakeFiles/hpx.dir/performance_counters/counter_parser.cpp.o
[ 20%] Building CXX object src/CMakeFiles/hpx.dir/performance_counters/counters.cpp.o
[ 20%] Building CXX object src/CMakeFiles/hpx.dir/performance_counters/manage_counter.cpp.o
In file included from /scratch/snx3000/biddisco/src/hpx/src/runtime/threads/detail/scheduled_thread_pool.cpp:7:0:
/scratch/snx3000/biddisco/src/hpx/hpx/runtime/threads/detail/scheduled_thread_pool_impl.hpp:862:36: error: no 'int64_t hpx::threads::detail::scheduled_thread_pool<Scheduler>::get_thread_phase_duration(std::size_t, bool)' member function declared in class 'hpx::threads::detail::scheduled_thread_pool<Scheduler>'
         std::size_t num, bool reset)
                                    ^
/scratch/snx3000/biddisco/src/hpx/hpx/runtime/threads/detail/scheduled_thread_pool_impl.hpp:927:36: error: no 'int64_t hpx::threads::detail::scheduled_thread_pool<Scheduler>::get_thread_duration(std::size_t, bool)' member function declared in class 'hpx::threads::detail::scheduled_thread_pool<Scheduler>'
         std::size_t num, bool reset)
                                    ^
/scratch/snx3000/biddisco/src/hpx/hpx/runtime/threads/detail/scheduled_thread_pool_impl.hpp:989:36: error: no 'int64_t hpx::threads::detail::scheduled_thread_pool<Scheduler>::get_thread_phase_overhead(std::size_t, bool)' member function declared in class 'hpx::threads::detail::scheduled_thread_pool<Scheduler>'
         std::size_t num, bool reset)
                                    ^
/scratch/snx3000/biddisco/src/hpx/hpx/runtime/threads/detail/scheduled_thread_pool_impl.hpp:1082:36: error: no 'int64_t hpx::threads::detail::scheduled_thread_pool<Scheduler>::get_thread_overhead(std::size_t, bool)' member function declared in class 'hpx::threads::detail::scheduled_thread_pool<Scheduler>'
         std::size_t num, bool reset)
                                    ^
/scratch/snx3000/biddisco/src/hpx/hpx/runtime/threads/detail/scheduled_thread_pool_impl.hpp:1172:36: error: no 'int64_t hpx::threads::detail::scheduled_thread_pool<Scheduler>::get_cumulative_thread_duration(std::size_t, bool)' member function declared in class 'hpx::threads::detail::scheduled_thread_pool<Scheduler>'
         std::size_t num, bool reset)
                                    ^
/scratch/snx3000/biddisco/src/hpx/hpx/runtime/threads/detail/scheduled_thread_pool_impl.hpp:1217:36: error: no 'int64_t hpx::threads::detail::scheduled_thread_pool<Scheduler>::get_cumulative_thread_overhead(std::size_t, bool)' member function declared in class 'hpx::threads::detail::scheduled_thread_pool<Scheduler>'
         std::size_t num, bool reset)
```                                    ^
@biddisco
Copy link
Contributor Author

biddisco commented May 5, 2019

Note that I tried building HPX with idle counters to collect data for the upcoming project proposal performance analysis section, so this is and urgent problem that I won't be able to look at for now.

@hkaiser hkaiser added this to the 1.3.0 milestone May 5, 2019
@hkaiser
Copy link
Member

hkaiser commented May 5, 2019

@biddisco please see #3837 for a fix.

@biddisco
Copy link
Contributor Author

biddisco commented May 5, 2019

adding -DHPX_WITH_THREAD_CUMULATIVE_COUNTS=On did not help, but the #3837 branch fixes it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants