Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block executor does not work with --hpx:bind=none #4772

Closed
msimberg opened this issue Jun 19, 2020 · 5 comments
Closed

Block executor does not work with --hpx:bind=none #4772

msimberg opened this issue Jun 19, 2020 · 5 comments

Comments

@msimberg
Copy link
Contributor

The resource partitioner returns empty pu masks if --hpx:bind=none is given on the command line, and the block executor ends up not having any threads to run tasks on. This could be fixed either by returning full machine masks instead of empty masks with none, or have the block executor handle empty masks separately. This is low priority for me, but if someone encounters this issue and wants it fixed please comment here.

@hkaiser
Copy link
Member

hkaiser commented Jun 19, 2020

FWIW, I had assumed that --hpx:bind=none already returns full masks. Otherwise not just the block executor should fail.

@msimberg
Copy link
Contributor Author

That would make sense, but I think we have special handling for empty masks. Making it use the full machine mask instead would probably simplify some of the resource partitioner code.

@stale
Copy link

stale bot commented Dec 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Jun 16, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the tag: wontfix label Jun 16, 2021
@stale
Copy link

stale bot commented Jul 21, 2021

This issue has been automatically closed. Please re-open if necessary.

@stale stale bot closed this as completed Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants