Remaining find algorithms implemented, N4071 #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,6 +4,8 @@ | |||
| # file LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt) | |||
|
|
|||
| set(tests | |||
| adjacentfind | |||
| adjacentfind_binary | |||
47 tasks
|
This is related to #1141: Implement N4071 on top of HPX |
| } | ||
| } | ||
| return result; | ||
| return std::find_end(first1,last1,first2,last2,op); |
There was a problem hiding this comment.
May I ask to more strictly conform to code formatting guidelines, i.e. keep formatting consistent inside each file (here: add spaces after ',')?
|
In order for the new algorithms to show up in the generated documentation index those will need to be added to the file hpx.idx. |
|
Test this please |
| @@ -82,6 +82,8 @@ parallel::find "find" "hpx\.parallel\.v1\.find$" | |||
| parallel::find_if "find_if" "hpx\.parallel\.v1\.find_if$" | |||
| parallel::find_if_not "find_if_not" "hpx\.parallel\.v1\.find_if_not.*" | |||
| parallel::find_end "find_end" "hpx\.parallel\.v1\.find_end_id.*" | |||
| parallel::find_first_of "find_first_of" "hpx\.parallel\.v1\.find_end_id.*" | |||
| parallel::adjacent_find "adjacent_find" "hpx\.parallel\.v1\adjacent_find.*" | |||
| @@ -468,6 +470,7 @@ namespace hpx { namespace parallel { HPX_INLINE_NAMESPACE(v1) | |||
| } | |||
| } | |||
| return result; | |||
| */ | |||
There was a problem hiding this comment.
No need to keep the inefficient manual code around
…der, fixing docs generation for find algorithms
hkaiser
added a commit
that referenced
this pull request
Aug 23, 2014
Remaining find algorithms implemented, N4071
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remaining find algorithms have been finished and are ready to merge into the master branch. They are
first_first_ofadjacent_find