Adding new performance counter exposing overall scheduler time

[hkaiser]

• adds missing perf counter: /threads/time/overall

[hkaiser]

@pagrubel This adds the counter you were asking for. The already existing counter threads/time/cumulative exposes the time spent executing HPX threads (exec-time), and this new counter /threads/time/overall exposes the overall time the scheduler is running (tfunc-times). Please let us know if this is what you need.

[sithhell]

What's the difference to the already existing uptime performance counter?

[hkaiser]

What's the difference to the already existing uptime performance counter?

@pagrubel asked to exposed the values which are being used to calculate the various derived counters. This is for her to reduce the error margin as she can calculate all derived values herself. This would also reduce the measurement overhead as she is collecting a large amount of those derived counters. The difference to the uptime counter is that this new counter exposes the core-specific timer instead of an arbitrary one.

[pagrubel]

the counter is not available see, I tried changing line 658 but it still did not work, also it looks like this wouldn't require the idle rate flag but shouldn't it?

hpx/src/runtime/threads/threadmanager.cpp

Lines 657 to 663 in 6de523d

	// /threads{locality#%d/total}/time/overall
	// /threads{locality#%d/worker-thread%d}/time/overall
	{ "time/cumulative",
	util::bind(&ti::get_cumulative_duration, this, -1, _1),
	util::bind(&ti::get_cumulative_duration, this,
	static_cast<std::size_t>(paths.instanceindex_), _1),
	"worker-thread", shepherd_count

[hkaiser]

@pagrubel This should be fine now. And no, you don't need to enable the idle-rate stuff. This information is collected always.

[pagrubel]

@hkaiser did you push a change I don't see one

[pagrubel]

@hkaiser
This counter doesn't seem to work when hpx is built without the idle_rate counter flag it gives 0
~/build/hpx_buildrelease/bin/hello_world --hpx:print-counter /threads{locality#*/total}/time/overall -t4
hello world from OS-thread 3 on locality 0
hello world from OS-thread 1 on locality 0
hello world from OS-thread 2 on locality 0
hello world from OS-thread 0 on locality 0
/threads{locality#0/total}/time/overall,1,0.009978,[s],0,[ns]

but does when the flag is set for the build:
~/build/hpx_buildidle/bin/hello_world --hpx:print-counter /threads{locality#*/total}/time/overall -t4
hello world from OS-thread 2 on locality 0
hello world from OS-thread 3 on locality 0
hello world from OS-thread 1 on locality 0
hello world from OS-thread 0 on locality 0
/threads{locality#0/total}/time/overall,1,0.009319,[s],3.61332e+07,[ns]

[hkaiser]

So I stand corrected... (I should have looked more carefully), I'll add a note to that effect to the docs.

[pagrubel]

I find myself going down rabbit holes with this seems like some of the other counters are not working correctly

[hkaiser]

I find myself going down rabbit holes with this seems like some of the other counters are not working correctly

Could you be a bit more specific, please?

[pagrubel]

I will try but I need to leave this right now

[hkaiser]

I'm going to merge this. Please open a ticket if you're running into problems with the new counter.